From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: Intel: Make sure we only build SST drivers on X86 Date: Wed, 19 Feb 2014 16:21:05 +0100 Message-ID: References: <1392818784-6248-1-git-send-email-liam.r.girdwood@linux.intel.com> <1392818784-6248-2-git-send-email-liam.r.girdwood@linux.intel.com> <20140219150040.GD2669@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 3A50D2658F9 for ; Wed, 19 Feb 2014 16:21:06 +0100 (CET) In-Reply-To: <20140219150040.GD2669@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Liam Girdwood , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 20 Feb 2014 00:00:40 +0900, Mark Brown wrote: > > On Wed, Feb 19, 2014 at 02:06:24PM +0000, Liam Girdwood wrote: > > Disable build on non X86 architectures. This fixes the following build > > errors on PPC :- > > > sound/soc/intel/sst-dsp.c: In function 'sst_dsp_outbox_write': > > sound/soc/intel/sst-dsp.c:218:2: error: implicit declaration of function 'memcpy_toio' [-Werror=implicit-function-declaration] > > memcpy_toio(sst->mailbox.out_base, message, bytes); > > ^ > > But lots of architectures do actually have these operations, I suspect > looking at some of the existing users depending on PCI is enough if > excessively strict (this will improve build coverage which tends to be > useful even if the driver can't be run). Yes. I guess including linux/io.h should fix the build issue. Though, limiting the build to X86 isn't bad particularly for this driver. Takashi