From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: Add missing include of pcm.h to pcm_params.h
Date: Wed, 20 Jun 2012 17:51:29 +0200 [thread overview]
Message-ID: <s5h1ulaf0ce.wl%tiwai@suse.de> (raw)
In-Reply-To: <20120620093425.GA3978@opensource.wolfsonmicro.com>
At Wed, 20 Jun 2012 10:34:25 +0100,
Mark Brown wrote:
>
> On Wed, Jun 20, 2012 at 07:47:25AM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
>
> > > There's a dependency but no #include.
>
> > I don't mind to put it, but it wasn't done because we didn't want to
> > let the driver code including only pcm_params.h without pcm.h.
>
> I noticed it because I was writing some library code which only directly
> referenced things in pcm_params.h so just included that directly. The
> general idea is that headers shouldn't have external dependencies...
True.
This can be an endless bikeshed discussion, so I simply applied the
patch now.
thanks,
Takashi
prev parent reply other threads:[~2012-06-20 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 18:31 [PATCH] ALSA: Add missing include of pcm.h to pcm_params.h Mark Brown
2012-06-20 5:47 ` Takashi Iwai
2012-06-20 9:34 ` Mark Brown
2012-06-20 15:51 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1ulaf0ce.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox