* [PATCH] alsa-lib: ucm: allow values to be read from devices
@ 2011-03-15 16:45 Margarita Olaya
2011-03-16 22:27 ` Liam Girdwood
2011-03-18 15:44 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Margarita Olaya @ 2011-03-15 16:45 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
This allows devices value to be read using the get_value().
Also fix a little formatting.
Signed-off-by: Margarita Olaya Cabrera <magi@slimlogic.co.uk>
---
src/ucm/main.c | 19 +++++++++++++------
1 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/src/ucm/main.c b/src/ucm/main.c
index 42fd373..fb11e61 100644
--- a/src/ucm/main.c
+++ b/src/ucm/main.c
@@ -1063,20 +1063,27 @@ static int get_value3(const char **value,
* \return Zero on success (value is filled), otherwise a negative error code
*/
static int get_value(snd_use_case_mgr_t *uc_mgr,
- const char *identifier,
- const char **value,
- const char *modifier)
+ const char *identifier,
+ const char **value,
+ const char *item)
{
- struct use_case_modifier *mod;
+ struct use_case_modifier *mod;
+ struct use_case_device *dev;
int err;
- if (modifier != NULL) {
- mod = find_modifier(uc_mgr, modifier);
+ if (item != NULL) {
+ mod = find_modifier(uc_mgr, item);
if (mod != NULL) {
err = get_value1(value, &mod->value_list, identifier);
if (err >= 0 || err != -ENOENT)
return err;
}
+ dev = find_device(uc_mgr->active_verb, item);
+ if (dev != NULL) {
+ err = get_value1(value, &dev->value_list, identifier);
+ if (err >=0 || err != -ENOENT)
+ return err;
+ }
}
err = get_value1(value, &uc_mgr->active_verb->value_list, identifier);
if (err >= 0 || err != -ENOENT)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] alsa-lib: ucm: allow values to be read from devices
2011-03-15 16:45 [PATCH] alsa-lib: ucm: allow values to be read from devices Margarita Olaya
@ 2011-03-16 22:27 ` Liam Girdwood
2011-03-18 15:36 ` Margarita Olaya
2011-03-18 15:44 ` Takashi Iwai
1 sibling, 1 reply; 5+ messages in thread
From: Liam Girdwood @ 2011-03-16 22:27 UTC (permalink / raw)
To: Margarita Olaya; +Cc: alsa-devel, Mark Brown
On Tue, 2011-03-15 at 10:45 -0600, Margarita Olaya wrote:
> This allows devices value to be read using the get_value().
> Also fix a little formatting.
>
> Signed-off-by: Margarita Olaya Cabrera <magi@slimlogic.co.uk>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] alsa-lib: ucm: allow values to be read from devices
2011-03-16 22:27 ` Liam Girdwood
@ 2011-03-18 15:36 ` Margarita Olaya
0 siblings, 0 replies; 5+ messages in thread
From: Margarita Olaya @ 2011-03-18 15:36 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, Mark Brown, Liam Girdwood
Hi Jaroslav,
On Wed, Mar 16, 2011 at 4:27 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Tue, 2011-03-15 at 10:45 -0600, Margarita Olaya wrote:
>> This allows devices value to be read using the get_value().
>> Also fix a little formatting.
>>
>> Signed-off-by: Margarita Olaya Cabrera <magi@slimlogic.co.uk>
>
> Acked-by: Liam Girdwood <lrg@ti.com>
>
Any chance this patch can be applied soon?
Thanks,
Margarita
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] alsa-lib: ucm: allow values to be read from devices
2011-03-15 16:45 [PATCH] alsa-lib: ucm: allow values to be read from devices Margarita Olaya
2011-03-16 22:27 ` Liam Girdwood
@ 2011-03-18 15:44 ` Takashi Iwai
2011-03-18 16:19 ` Margarita Olaya
1 sibling, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2011-03-18 15:44 UTC (permalink / raw)
To: Margarita Olaya; +Cc: alsa-devel, Mark Brown
At Tue, 15 Mar 2011 10:45:19 -0600,
Margarita Olaya wrote:
>
> This allows devices value to be read using the get_value().
> Also fix a little formatting.
>
> Signed-off-by: Margarita Olaya Cabrera <magi@slimlogic.co.uk>
> ---
> src/ucm/main.c | 19 +++++++++++++------
> 1 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/src/ucm/main.c b/src/ucm/main.c
> index 42fd373..fb11e61 100644
> --- a/src/ucm/main.c
> +++ b/src/ucm/main.c
> @@ -1063,20 +1063,27 @@ static int get_value3(const char **value,
> * \return Zero on success (value is filled), otherwise a negative error code
> */
> static int get_value(snd_use_case_mgr_t *uc_mgr,
> - const char *identifier,
> - const char **value,
> - const char *modifier)
> + const char *identifier,
> + const char **value,
> + const char *item)
Please fix also the corresponding DocBook comment when you change the
parameter (and semantics).
> + dev = find_device(uc_mgr->active_verb, item);
> + if (dev != NULL) {
> + err = get_value1(value, &dev->value_list, identifier);
> + if (err >=0 || err != -ENOENT)
Put a space after '>='.
Could you resubmit with these fixes?
thanks,
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] alsa-lib: ucm: allow values to be read from devices
2011-03-18 15:44 ` Takashi Iwai
@ 2011-03-18 16:19 ` Margarita Olaya
0 siblings, 0 replies; 5+ messages in thread
From: Margarita Olaya @ 2011-03-18 16:19 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Mark Brown
Hi Takashi,
On Fri, Mar 18, 2011 at 9:44 AM, Takashi Iwai <tiwai@suse.de> wrote:
> At Tue, 15 Mar 2011 10:45:19 -0600,
> Margarita Olaya wrote:
>>
>> This allows devices value to be read using the get_value().
>> Also fix a little formatting.
>>
>> Signed-off-by: Margarita Olaya Cabrera <magi@slimlogic.co.uk>
>> ---
>> src/ucm/main.c | 19 +++++++++++++------
>> 1 files changed, 13 insertions(+), 6 deletions(-)
>>
>> diff --git a/src/ucm/main.c b/src/ucm/main.c
>> index 42fd373..fb11e61 100644
>> --- a/src/ucm/main.c
>> +++ b/src/ucm/main.c
>> @@ -1063,20 +1063,27 @@ static int get_value3(const char **value,
>> * \return Zero on success (value is filled), otherwise a negative error code
>> */
>> static int get_value(snd_use_case_mgr_t *uc_mgr,
>> - const char *identifier,
>> - const char **value,
>> - const char *modifier)
>> + const char *identifier,
>> + const char **value,
>> + const char *item)
>
> Please fix also the corresponding DocBook comment when you change the
> parameter (and semantics).
>
>> + dev = find_device(uc_mgr->active_verb, item);
>> + if (dev != NULL) {
>> + err = get_value1(value, &dev->value_list, identifier);
>> + if (err >=0 || err != -ENOENT)
>
> Put a space after '>='.
>
> Could you resubmit with these fixes?
>
Thanks for review, I will resubmit the patch shortly :)
Regards,
Margarita
>
> thanks,
>
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-18 16:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-15 16:45 [PATCH] alsa-lib: ucm: allow values to be read from devices Margarita Olaya
2011-03-16 22:27 ` Liam Girdwood
2011-03-18 15:36 ` Margarita Olaya
2011-03-18 15:44 ` Takashi Iwai
2011-03-18 16:19 ` Margarita Olaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).