From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] alsa-lib: ucm: allow values to be read from devices Date: Fri, 18 Mar 2011 16:44:59 +0100 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 342AB1039F9 for ; Fri, 18 Mar 2011 16:45:02 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Margarita Olaya Cc: alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org At Tue, 15 Mar 2011 10:45:19 -0600, Margarita Olaya wrote: > > This allows devices value to be read using the get_value(). > Also fix a little formatting. > > Signed-off-by: Margarita Olaya Cabrera > --- > src/ucm/main.c | 19 +++++++++++++------ > 1 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/src/ucm/main.c b/src/ucm/main.c > index 42fd373..fb11e61 100644 > --- a/src/ucm/main.c > +++ b/src/ucm/main.c > @@ -1063,20 +1063,27 @@ static int get_value3(const char **value, > * \return Zero on success (value is filled), otherwise a negative error code > */ > static int get_value(snd_use_case_mgr_t *uc_mgr, > - const char *identifier, > - const char **value, > - const char *modifier) > + const char *identifier, > + const char **value, > + const char *item) Please fix also the corresponding DocBook comment when you change the parameter (and semantics). > + dev = find_device(uc_mgr->active_verb, item); > + if (dev != NULL) { > + err = get_value1(value, &dev->value_list, identifier); > + if (err >=0 || err != -ENOENT) Put a space after '>='. Could you resubmit with these fixes? thanks, Takashi