Re: [PATCH 24/25] sound: Use static const char arrays

[Takashi Iwai <tiwai@suse.de>]

At Mon, 13 Sep 2010 12:48:02 -0700,
Joe Perches wrote:
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  sound/core/misc.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/core/misc.c b/sound/core/misc.c
> index 2c41825..0e5e77f 100644
> --- a/sound/core/misc.c
> +++ b/sound/core/misc.c
> @@ -64,12 +64,15 @@ static int print_snd_pfx(unsigned int level, const char *path, int line,
>  			 const char *format)
>  {
>  	const char *file = sanity_file_name(path);
> -	char tmp[] = "<0>";
> +	char tmp[sizeof("<0>")];
>  	const char *pfx = level ? KERN_DEBUG : KERN_DEFAULT;
>  	int ret = 0;
>  
>  	if (format[0] == '<' && format[2] == '>') {
> +		tmp[0] = '<';
>  		tmp[1] = format[1];
> +		tmp[2] = '>';
> +		tmp[3] = 0;
>  		pfx = tmp;
>  		ret = 1;
>  	}

Would this case save something really...?


thanks,

Takashi