Re: [PATCH] Sync with AudioScience current CVS at version 4.03.04

Re: [PATCH] Sync with AudioScience current CVS at version 4.03.04

[Eliot Blennerhassett]

Greetings,

The just submitted patch requires matching firmware
http://audioscience.com/internet/download/firmware/dspbins40304.zip

As usual, my apologies for the large patch.  Unfortunately it was not
possible to split into unrelated subpatches without manually recreating
the commit history from our CVS repository.

>  b/pci/asihpi/Makefile           |    2 
>  b/pci/asihpi/asihpi.c           |  297 +++----
>  b/pci/asihpi/hpi.h              | 1446 ++++++++++++++++++------------------
>  b/pci/asihpi/hpi6000.c          |  102 +-
>  b/pci/asihpi/hpi6205.c          |  678 +++++++++--------
>  b/pci/asihpi/hpi6205.h          |   23 
>  b/pci/asihpi/hpi_internal.h     |  537 +++++++++++--
>  b/pci/asihpi/hpicmn.c           |   68 -
>  b/pci/asihpi/hpidebug.c         |   40 -
>  b/pci/asihpi/hpidebug.h         |   44 -
>  b/pci/asihpi/hpidspcd.h         |   37 
>  b/pci/asihpi/hpifunc.c          | 1571 ++++++++++++++++++++++++++--------------
>  b/pci/asihpi/hpimsginit.c       |   92 +-
>  b/pci/asihpi/hpimsginit.h       |   33 
>  b/pci/asihpi/hpimsgx.c          |  187 ++--
>  b/pci/asihpi/hpioctl.c          |  202 +++--
>  b/pci/asihpi/hpios.c            |  147 +++
>  b/pci/asihpi/hpios.h            |  234 ++++-
>  b/pci/asihpi/hpipcida.h         |    6 
>  pci/asihpi/hpios_linux_kernel.c |  116 --
>  pci/asihpi/hpios_linux_kernel.h |  189 ----
>  21 files changed, 3596 insertions(+), 2455 deletions(-)

regards

Eliot Blennerhassett
AudioScience Inc.

Re: [PATCH] Sync with AudioScience current CVS at version 4.03.04

[Takashi Iwai]

At Tue, 02 Feb 2010 21:16:11 +1300,
Eliot Blennerhassett wrote:
> 
> Greetings,
> 
> The just submitted patch requires matching firmware
> http://audioscience.com/internet/download/firmware/dspbins40304.zip
> 
> As usual, my apologies for the large patch.  Unfortunately it was not
> possible to split into unrelated subpatches without manually recreating
> the commit history from our CVS repository.

Thanks for the patch.  I applied now together with the firmware update.

I suppose the new firmware is still compatible with the older one?
I'm asking this because the files are overridden.


thanks,

Takashi


> >  b/pci/asihpi/Makefile           |    2 
> >  b/pci/asihpi/asihpi.c           |  297 +++----
> >  b/pci/asihpi/hpi.h              | 1446 ++++++++++++++++++------------------
> >  b/pci/asihpi/hpi6000.c          |  102 +-
> >  b/pci/asihpi/hpi6205.c          |  678 +++++++++--------
> >  b/pci/asihpi/hpi6205.h          |   23 
> >  b/pci/asihpi/hpi_internal.h     |  537 +++++++++++--
> >  b/pci/asihpi/hpicmn.c           |   68 -
> >  b/pci/asihpi/hpidebug.c         |   40 -
> >  b/pci/asihpi/hpidebug.h         |   44 -
> >  b/pci/asihpi/hpidspcd.h         |   37 
> >  b/pci/asihpi/hpifunc.c          | 1571 ++++++++++++++++++++++++++--------------
> >  b/pci/asihpi/hpimsginit.c       |   92 +-
> >  b/pci/asihpi/hpimsginit.h       |   33 
> >  b/pci/asihpi/hpimsgx.c          |  187 ++--
> >  b/pci/asihpi/hpioctl.c          |  202 +++--
> >  b/pci/asihpi/hpios.c            |  147 +++
> >  b/pci/asihpi/hpios.h            |  234 ++++-
> >  b/pci/asihpi/hpipcida.h         |    6 
> >  pci/asihpi/hpios_linux_kernel.c |  116 --
> >  pci/asihpi/hpios_linux_kernel.h |  189 ----
> >  21 files changed, 3596 insertions(+), 2455 deletions(-)
> 
> regards
> 
> Eliot Blennerhassett
> AudioScience Inc.
> 

Re: [PATCH] Sync with AudioScience current CVS at version 4.03.04

[Eliot Blennerhassett]

Takashi Iwai wrote:
> At Tue, 02 Feb 2010 21:16:11 +1300,
> Eliot Blennerhassett wrote:
>> Greetings,
>>
>> The just submitted patch requires matching firmware
>> http://audioscience.com/internet/download/firmware/dspbins40304.zip
>>
>> As usual, my apologies for the large patch.  Unfortunately it was not
>> possible to split into unrelated subpatches without manually recreating
>> the commit history from our CVS repository.
> 
> Thanks for the patch.  I applied now together with the firmware update.

Thank you.

> I suppose the new firmware is still compatible with the older one?
> I'm asking this because the files are overridden.

In this case, the firmware and driver are a pair that must go together.
I.e. both the driver and the firmware must be updated together.

If the versions do not match, a warning will be logged.

However, now you mention it, I will look at making it a failure if the
major version of driver vs fimware does not match (we changed from 3. to
4. because the message format is incompatible).
I'll follow up with another patch in the next few days.

regards

Eliot