From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [alsa-cvslog] alsa-kernel: Official ALSA project GIT repository for Linux 2.6 branch, master now at v2.6.31-rc8-407-gfc9e4a3 Date: Thu, 08 Oct 2009 14:15:21 +0200 Message-ID: References: <20091006063609.B06E110381F@alsa0.perex.cz> <4ACAF4AC.3000608@ladisch.de> <4ACDCAAB.2060609@ladisch.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id C6D8510394C for ; Thu, 8 Oct 2009 14:15:21 +0200 (CEST) In-Reply-To: <4ACDCAAB.2060609@ladisch.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch Cc: alsa-devel@alsa-project.org, Honza Maly List-Id: alsa-devel@alsa-project.org At Thu, 08 Oct 2009 13:19:07 +0200, Clemens Ladisch wrote: > > jmal8295 wrote: > > And I _will_ be regarding it as regression if I lose possibility to > > change volume of the four streams independently. > > Okay, as long as there is no application to handle PCM-interface > controls, the DXS controls should not be hidden this way. > > Anyway, the volume level regression can be solved by any renaming, so > let's do just that. Takashi, please pick the patch below instead. Too late. I already picked up the older patch. Takashi > ========== > > sound: via82xx: rename DXS volume controls > > Only some insiders know what the "VIA DXS" controls actually control, so > change them to a more descriptive name. > > Commit b452e08e73c0e3dbb0be82130217be4b7084299e in 2.6.30 broke the > restoring of these volumes by "alsactl restore" that most distributions > use; the renaming in this patch cures that regression by preventing > alsactl from applying the old, wrong volume levels to the new controls. > http://bugzilla.kernel.org/show_bug.cgi?id=14151 > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=532613 > > Signed-off-by: Clemens Ladisch > Cc: > > --- a/sound/pci/via82xx.c > +++ b/sound/pci/via82xx.c > @@ -1705,7 +1705,7 @@ > }; > > static struct snd_kcontrol_new snd_via8233_dxs_volume_control __devinitdata = { > - .name = "VIA DXS Playback Volume", > + .name = "PCM Stream Playback Volume", > .iface = SNDRV_CTL_ELEM_IFACE_MIXER, > .access = (SNDRV_CTL_ELEM_ACCESS_READWRITE | > SNDRV_CTL_ELEM_ACCESS_TLV_READ), >