From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/4] ASoC: TLV320AIC23B Support more sample rates Date: Thu, 06 Nov 2008 12:03:59 +0100 Message-ID: References: <20081105185220.GA10816@rakim.wolfsonmicro.main> <1225911211-22474-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20081106104905.GA26469@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 40A0D244EB for ; Thu, 6 Nov 2008 12:04:00 +0100 (CET) In-Reply-To: <20081106104905.GA26469@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Troy Kisky List-Id: alsa-devel@alsa-project.org At Thu, 6 Nov 2008 10:49:06 +0000, Mark Brown wrote: > > On Wed, Nov 05, 2008 at 09:35:01PM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > > + return score; > > > > + return 0xffffffff; > > > -1 would be simpler and safer (for possible missing f's). > > I'm not sure that'd add to the clarity - the goal isn't to have all bits > set, the goal is to have a much larger score than could ever otherwise > be achieved so putting in a very large constant expresses that much more > directly. In that case, the best form is UINT_MAX. Takashi