From: Takashi Iwai <tiwai@suse.de>
To: Mikael Magnusson <mikaelmagnusson@glocalnet.net>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa-tools
Date: Tue, 17 May 2005 10:56:43 +0200 [thread overview]
Message-ID: <s5h1x86qlh0.wl@alsa2.suse.de> (raw)
In-Reply-To: <4288B114.1000900@glocalnet.net>
At Mon, 16 May 2005 16:41:24 +0200,
Mikael Magnusson wrote:
>
> ld10k1_configure.patch
> ld10k1_makefile.patch
> Removes ALSA_CFLAGS and ALSA_LIBS in configure.in, they are added to
> CFLAGS and LDADD in src/Makefile.am already. Adds "-Wall" to CFLAGS only
> if CFLAGS is undefined.
>
> qlo10k1_configure.patch
> qlo10k1_makefile.patch
> Adds LD10K1_CFLAGS and LD10K1_LDFLAGS in src/Makefile.am, and moves
> QT_CXXFLAGS to the makefile.
>
> qlo10k1_acinclude.patch
> Fixes pattern in gw_CHECK_QT not to match files that the linker won't
> use, for example libqt.so.3 . Needed if both libqt and libqt-mt shared
> libraries are installed, but only the libqt-mt development library.
Thanks. I think we can get rid of -Wall.
It's not mandatory at all. Let's simply remove CFLAGS=XXX lines.
Could you regenerate patches with that change?
Takashi
-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click
next prev parent reply other threads:[~2005-05-17 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-16 14:41 [PATCH] alsa-tools Mikael Magnusson
2005-05-17 8:56 ` Takashi Iwai [this message]
2005-05-17 15:50 ` Mikael Magnusson
2005-05-17 16:13 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2005-05-16 14:39 Mikael Magnusson
2005-05-16 17:02 ` Mikael Magnusson
2005-05-16 19:03 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1x86qlh0.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=mikaelmagnusson@glocalnet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox