From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3244C433EF for ; Fri, 22 Apr 2022 05:59:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B28D21714; Fri, 22 Apr 2022 07:58:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B28D21714 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650607176; bh=W/W0gFjonpzuVtUNdbfG4bQQGKL2d8gH6NNeajT9BJE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sesFE1OIyulkdMh6rZtdLIkZR5sndQU1hrbdeh5orXz52vHzY6PhbHH+MubMsKZ1v ikgwXpQTBOtAm3d7AylAIk/G8QiKIA47IMmHhkz9hYBal9GeBu1QV+DVGBgdjzyypn D1hPBM5UdiY2XhaTrn2k1T5QJdw1JBh/XaCREhwo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5C04DF80154; Fri, 22 Apr 2022 07:58:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 35702F80245; Fri, 22 Apr 2022 07:58:45 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3A965F80134 for ; Fri, 22 Apr 2022 07:58:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3A965F80134 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="xASxMAIu"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+1FJLxcX" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 71CB31F745; Fri, 22 Apr 2022 05:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1650607118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mAdj96DBsr5nxeDeyqlp0nmr0SjkdrgI+4axBdvYC5w=; b=xASxMAIubK7nP6qIQlJ0If3b6gpOnAZiMAMO8pyQe92Iws8uuW7OeziZbbfIkOIKk6lhP6 OKiXcJWeANEdpXRhmtMrCcV7XZaQryexNsX2kWNMy6Vq1K4kf7ZrYGMFBWBO6jmzW5sqbD NyHW8ylfkozghfoZiyYlC+dJdoJfweU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1650607118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mAdj96DBsr5nxeDeyqlp0nmr0SjkdrgI+4axBdvYC5w=; b=+1FJLxcXtttys3GmCcGIqUu8myexJUnlFaOUFhgiEiUS3rRWhQouq/QfxQzFDjp9V4D1uZ +dUdggt9DoU6M1Bg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 640EB2C14B; Fri, 22 Apr 2022 05:58:38 +0000 (UTC) Date: Fri, 22 Apr 2022 07:58:38 +0200 Message-ID: From: Takashi Iwai To: Miles Chen Subject: Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used In-Reply-To: <20220422025312.7718-1-miles.chen@mediatek.com> References: <20220422025312.7718-1-miles.chen@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, tiwai@suse.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 22 Apr 2022 04:53:12 +0200, Miles Chen wrote: > > Hi Taksshi, > > >> We observed: 'dmasound_setup' defined but not used error with > >> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build. > >> > >> Fix it by adding __maybe_unused to dmasound_setup. > >> > >> Error(s): > >> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function] > >> > >> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m") > >> Signed-off-by: Miles Chen > >> Cc: Takashi Iwai > > > >Thanks, applied. > > This patch is needed in 5.18-rc3 [1] too, should I submit another patch or > you can pick it to the mainstream? It's included in the branch for the next PR to 5.18. thanks, Takashi