From: Takashi Iwai <tiwai@suse.de>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org,
Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()
Date: Tue, 19 Apr 2022 09:01:34 +0200 [thread overview]
Message-ID: <s5h35i936b5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220416064418.2364582-1-lucas.demarchi@intel.com>
On Sat, 16 Apr 2022 08:44:18 +0200,
Lucas De Marchi wrote:
>
> pci_get_class() will already unref the pci device passed as argument.
> So if it's unconditionally unref'ed, even if the loop is not stopped,
> there will be one too many unref for each device not matched.
>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5701
> Fixes: 0dc2696a4623 ("ALSA: hda/i915 - skip acomp init if no matching display")
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Thanks, applied now.
But the Fixes commit id was wrong. I corrected to the right upstream
one, c9db8a30d9f0.
Takashi
next prev parent reply other threads:[~2022-04-19 7:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 6:44 [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put() Lucas De Marchi
2022-04-17 10:13 ` Kai Vehmanen
2022-04-18 4:50 ` [Intel-gfx] " Lucas De Marchi
2022-04-19 5:54 ` Takashi Iwai
2022-04-19 6:26 ` Lucas De Marchi
2022-04-19 6:40 ` Takashi Iwai
2022-04-19 6:56 ` Takashi Iwai
2022-04-19 7:01 ` Takashi Iwai [this message]
2022-04-19 15:05 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h35i936b5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox