From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 658B3C433F5 for ; Wed, 9 Feb 2022 07:10:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6080817DB; Wed, 9 Feb 2022 08:09:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6080817DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644390623; bh=TrXeJLhvXUY46DAZU/QbMVJ6PO7d+51H7XCrSiLO7Dw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WINW25so3ScByw6YsBdaN/iERJEMgaYLgJXaK/Srd8K4ZvFzE0tignp9+gI+8p9Us IelJRPS5LgcYF30LLUTkahgnEohAOplkqoEqQhEg1SWCWUMirLGm8Atvcjn6bKl37Y ddI2OjCKKqoWMfypWoKV89EBhGkYoYG+j9afhexM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C7D5DF8014B; Wed, 9 Feb 2022 08:09:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 340FDF8016A; Wed, 9 Feb 2022 08:09:31 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 380E0F800ED for ; Wed, 9 Feb 2022 08:09:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 380E0F800ED Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="JaP2Zh/L"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="LfpkBgsb" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 11579210F1; Wed, 9 Feb 2022 07:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644390565; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dittJlgPCXfXnSmHz5MOmE4VVHrmBCwHv/MXR6K2oV4=; b=JaP2Zh/LA/wjDxFE4rsruNMjkRWQuk7rBlrhGpidQT6jX74Jj+Uua9rQEODw+7T6W/W6bB v8Z9lpbClCH2OfwSVG9hWcoDvwJuYRdWeOmuOE/ytNJ8rZoOHTzPpJGPCJBkau3r08DeCz octIdMx/jpGQUap8raIq5GbylNHObxk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644390565; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dittJlgPCXfXnSmHz5MOmE4VVHrmBCwHv/MXR6K2oV4=; b=LfpkBgsbMjb5KtjkiOTt9e8OmTulhzudS4tSlrLG4DotaelaMRCZBvWA4rLUDaJPBYQrtm 7ImaZLoskAzxCyBQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 03363A3B83; Wed, 9 Feb 2022 07:09:25 +0000 (UTC) Date: Wed, 09 Feb 2022 08:09:24 +0100 Message-ID: From: Takashi Iwai To: Mohan Kumar Subject: Re: [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication In-Reply-To: <20220209042326.15764-4-mkumard@nvidia.com> References: <20220209042326.15764-1-mkumard@nvidia.com> <20220209042326.15764-4-mkumard@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, spujar@nvidia.com, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, jonathanh@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 09 Feb 2022 05:23:23 +0100, Mohan Kumar wrote: > > --- a/include/sound/hda_codec.h > +++ b/include/sound/hda_codec.h > @@ -240,6 +240,10 @@ struct hda_codec { > unsigned int single_adc_amp:1; /* adc in-amp takes no index > * (e.g. CX20549 codec) > */ > + unsigned int hdmi_intr_trig_ctrl:1; /* hdmi interrupt trigger > + * control flag > + * (e.g. Nvidia codecs) > + */ This flag is specific to (Nvidia) HDMI codec and referred only from patch_hdmi.c, right? If so, the flag would be better put locally to struct hdmi_spec instead of a global hda_codec. thanks, Takashi