From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5743C3A5A9 for ; Sat, 2 May 2020 07:28:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C5E12137B for ; Sat, 2 May 2020 07:28:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rX7pF7ZV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C5E12137B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3D94516B6; Sat, 2 May 2020 09:27:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3D94516B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588404509; bh=0ooh7Tl7sQeXlk7JxmXXSXTFRcm6DyzwjJb2NXwcWXU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rX7pF7ZVGwhIzfDOoxy/ROMssKdd18rrKLXRdvqtkunF/ohLqGo5xiDjFFUK3vvS0 x8h0Me9kY8P/p2/SixDG4Vk3g4Mjk9PELcCSgMZNYs1Gu1GWd1RiAXyqZiWAUmuUpF iLb2RFaHDJcSkFs4jMt3lMjvhq+VaKpEFWWc2NRk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 169F7F801EB; Sat, 2 May 2020 09:27:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 03B76F801F7; Sat, 2 May 2020 09:27:37 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 912CAF80087 for ; Sat, 2 May 2020 09:27:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 912CAF80087 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6B6B0AC91; Sat, 2 May 2020 07:27:32 +0000 (UTC) Date: Sat, 02 May 2020 09:27:31 +0200 Message-ID: From: Takashi Iwai To: Lukas Wunner Subject: Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state In-Reply-To: <20200502071728.fn2fcqvt6aies3zu@wunner.de> References: <20200502071728.fn2fcqvt6aies3zu@wunner.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "Zhou, David\(ChunMing\)" , "alsa-devel@alsa-project.org" , Nicholas Johnson , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Takashi Iwai , "Deucher, Alexander" , Alex Deucher , "Koenig, Christian" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 02 May 2020 09:17:28 +0200, Lukas Wunner wrote: > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device *kdev, > > struct amdgpu_device *adev = dev->dev_private; > > struct drm_audio_component *acomp = data; > > > > + if (!device_link_add(hda_kdev, kdev, DL_FLAG_STATELESS | > > + DL_FLAG_PM_RUNTIME)) { > > + DRM_ERROR("DM: cannot add device link to audio device\n"); > > + return -ENOMEM; > > + } > > + > > Doesn't this duplicate drivers/pci/quirks.c:quirk_gpu_hda() ? Gah, you're right, that was the place I overlooked. It was a typical "false Eureka right-after-wakeup" phenomenon :) Need a vaccine aka coffee... So the runtime PM dependency must be already placed there, and the problem is not the lack of the dependency tree but the really other timing issue. Back to square. thanks, Takashi