From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DCFC54FCB for ; Fri, 24 Apr 2020 16:07:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43F3720706 for ; Fri, 24 Apr 2020 16:07:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="AEyykjUO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43F3720706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7F3AD16A8; Fri, 24 Apr 2020 18:06:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7F3AD16A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587744457; bh=uBgi0ly6J0E2C16oolKEtobx3m22M+p6XiwSmO2kJIA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AEyykjUOsRiU3bAEBTR6l0j7DaoxaP9WeowiHFjfmiFg5j1x3T8XP4QwMg2ZM6Tih 6CFJtGrYM1w2zukxxQgE3JmpF53022McNrt1wunJ+jEwGRlWIFwl4pYNZ4RrMwQP99 88F8Rw0UHE0e0jTeWCKTaygcqOUkjv0MLWSrIK0Q= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D6F26F80121; Fri, 24 Apr 2020 18:06:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 88CFAF80142; Fri, 24 Apr 2020 18:06:44 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C3607F80116 for ; Fri, 24 Apr 2020 18:06:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C3607F80116 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 53B6CACCE; Fri, 24 Apr 2020 16:06:38 +0000 (UTC) Date: Fri, 24 Apr 2020 18:06:38 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: snd-sof-intel-hda-common - add hda_model parameter and pass it to HDA codec driver In-Reply-To: <28900433-f2a7-bf4e-7861-5522f0aedee1@linux.intel.com> References: <20200424092520.23989-1-perex@perex.cz> <28900433-f2a7-bf4e-7861-5522f0aedee1@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: ALSA development , Mark Brown , Kai Vehmanen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 24 Apr 2020 17:44:27 +0200, Pierre-Louis Bossart wrote: > > > > >> Hmm, I wonder is this now doing more harm than good. Based on browsing > >> through the related code in hda-codec.c and friends, it would seem > >> "sofbus" as the default is mostly harmless, but I could have missed > >> something. > > > > That's currently harmless since no codec driver defines "sofbus" > > model, hence the HDA parser continues to match with the default > > quirks. OTOH, the fixed "sofbus" model is fairly useless. So, feel > > free to take my ack, too: > > For my education, are you saying that the default should be that the > modelname is NULL, and the hda auto parser will use known quirks based > on PCI/SSID information, and when the user sets the model name to a > non-NULL string it will force a specific quirk to be used? Yes. If the given string matches with the pre-defined table, the quirk entry is used and applied. If no string is given or it doesn't match, it continues to the fallback quirk, that is, matching with PCI SSID, then codec SSID. Takashi