From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87F6C282DD for ; Thu, 9 Jan 2020 18:58:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAE0020721 for ; Thu, 9 Jan 2020 18:58:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="smCN4plX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAE0020721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 228D81772; Thu, 9 Jan 2020 19:57:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 228D81772 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1578596313; bh=IuaosPx6S9qieqBBIGoOQhpSmG81LamEEa3YxWjz3iY=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=smCN4plXqudkXxve0qRtY63jsz8vBhn6BaKSCukmRfYyfcgZxXUmqRCfl/8exavR5 lW2tqRWozhlL10xhFRmu7NhD5Wcfgk/vOvnVjUiSni9L9C6muxw4C8bJY8iwPo/tnl OTnN0Jo9nW0tojCzRoXMVXstIKswzqxjlfu9Y8A8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 48305F8014E; Thu, 9 Jan 2020 19:57:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id ED3BDF8015B; Thu, 9 Jan 2020 19:57:39 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2C933F800E4 for ; Thu, 9 Jan 2020 19:57:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2C933F800E4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 48396B1EC; Thu, 9 Jan 2020 18:57:35 +0000 (UTC) Date: Thu, 09 Jan 2020 19:57:34 +0100 Message-ID: From: Takashi Iwai To: Sriram Periyasamy In-Reply-To: <20200109171833.GA2709@sriram-VirtualBox> References: <1578366545-30251-1-git-send-email-richtek.jeff.chang@gmail.com> <20200109171833.GA2709@sriram-VirtualBox> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com, Jeff Chang , broonie@kernel.org, matthias.bgg@gmail.com, jeff_chang@richtek.com, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH v4] ASoC: Add MediaTek MT6660 Speaker Amp Driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 09 Jan 2020 18:18:36 +0100, Sriram Periyasamy wrote: > > On Tue, Jan 07, 2020 at 11:09:05AM +0800, Jeff Chang wrote: > > From: Jeff Chang > > > > The MT6660 is a boosted BTL class-D amplifier with V/I sensing. > > A built-in DC-DC step-up converter is used to provide efficient > > power for class-D amplifier with multi-level class-G operation. > > The digital audio interface supports I2S, left-justified, > > right-justified, TDM and DSP A/B format for audio in with a data > > out used for chip information like voltage sense and current > > sense, which are able to be monitored via DATAO through proper > > > > diff --git a/sound/soc/codecs/mt6660.c b/sound/soc/codecs/mt6660.c > > new file mode 100644 > > index 0000000..b8fc53b > > --- /dev/null > > +++ b/sound/soc/codecs/mt6660.c > > @@ -0,0 +1,628 @@ > > > + > > +struct codec_reg_val { > > + u32 addr; > > + u32 mask; > > + u32 data; > > +}; > > packed structures could have been better. It depends. Packing may break alignment and the performance may suffer from it. So, in general, __packed is recommended when the size matters (e.g. lots of objects / arrays are created) or it's about ABI that needs the fixed consistent size. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel