From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: HDA: Fix several mismatch for
	register	mask and value
Date: Mon, 03 Sep 2018 23:50:15 +0200
Message-ID: <s5h36uqxnc8.wl-tiwai@suse.de>
References: <20180903024709.56749-1-yang.jie@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 9CBCA267668
 for <alsa-devel@alsa-project.org>; Mon,  3 Sep 2018 23:50:17 +0200 (CEST)
In-Reply-To: <20180903024709.56749-1-yang.jie@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Keyon Jie <yang.jie@linux.intel.com>
Cc: jeeja.kp@intel.com, alsa-devel@alsa-project.org, rakesh.a.ughreja@intel.com, vkoul@kernel.org, pierre-louis.bossart@linux.intel.com
List-Id: alsa-devel@alsa-project.org

On Mon, 03 Sep 2018 04:47:09 +0200,
Keyon Jie wrote:
> 
> E.g. for snd_hdac_ext_link_clear_stream_id(), we should set (1 << stream)
> as mask, and 0 as value, here correct it and several similar mismatches.
> 
> And, here also remove unreadable register_mask usage for those mask value
> updating.
> 
> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Thanks, applied now.

Looking at this nice fix, it worries me a bit about the quality of the
code there...  We may need to audit the whole code again.  Oh well.


Takashi