From: Takashi Iwai <tiwai@suse.de>
To: "Kumar, Abhijeet" <abhijeet.kumar@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Koul, Vinod" <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Singh, Guneshwor O" <guneshwor.o.singh@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, "Kp, Jeeja" <jeeja.kp@intel.com>,
"Tayal, SandeepX" <sandeepx.tayal@intel.com>,
"Prusty, Subhransu S" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output widget power state
Date: Fri, 12 Jan 2018 12:09:00 +0100 [thread overview]
Message-ID: <s5h373bpc4z.wl-tiwai@suse.de> (raw)
In-Reply-To: <60213CA7255C53479ADE3BCF0360117F02E7124F@PGSMSX104.gar.corp.intel.com>
On Fri, 12 Jan 2018 11:37:28 +0100,
Kumar, Abhijeet wrote:
>
> > It's better, but doesn't guarantee that the node reached the given power state. codec_read assures that the verb is sent and the codec gives the response. But it means only the target state gets updated, and doesn't mean that the actual state reached.
>
> Thanks Takashi for replying. I guess, I should make use of return value from codec_read and retry if power state is not set properly! I'll make those changes and update again. And just wondering, how does hdmi_codec_prepare() and hdmi_codec_complete() gurantee while powering up and down the afg ?
There are two power states in the codec node: the target and the
actual. By setting the power state, the target is set, but the actual
state change may still take some time. In such a case, you'd need to
wait until the actual state reaches. See hda_sync_power_state() in
the hda legacy.
Takashi
next prev parent reply other threads:[~2018-01-12 11:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 11:34 [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output widget power state abhijeet.kumar
2018-01-12 5:46 ` Vinod Koul
2018-01-12 8:25 ` Kumar, Abhijeet
2018-01-12 9:26 ` Takashi Iwai
2018-01-12 10:37 ` Kumar, Abhijeet
2018-01-12 11:09 ` Takashi Iwai [this message]
2018-01-12 8:36 ` Kumar, Abhijeet
2018-01-12 8:27 ` [PATCH v2] " abhijeet.kumar
2018-01-12 21:08 ` Applied "ASoC: hdac_hdmi: Ensuring proper setting of output widget power state" to the asoc tree Mark Brown
2018-01-12 21:20 ` Mark Brown
2018-01-13 4:49 ` Kumar, Abhijeet
2018-01-15 6:12 ` Vinod Koul
2018-01-15 10:30 ` Mark Brown
2018-01-15 10:41 ` Vinod Koul
2018-01-25 13:13 ` Kumar, Abhijeet
2018-01-23 17:30 ` [PATCH 1/3] ALSA: hda: Copying sync power state helper to core abhijeet.kumar
2018-01-23 17:30 ` [PATCH 2/3] ALSA: hda: Make use of core codec functions to sync power state abhijeet.kumar
2018-01-23 17:30 ` [PATCH 3/3] ASoC: hdac_hdmi : Ensuring proper setting of output widget " abhijeet.kumar
2018-02-12 13:04 ` Takashi Iwai
2018-02-14 16:20 ` Mark Brown
2018-02-15 8:30 ` Kumar, Abhijeet
2018-02-15 8:35 ` [PATCH] " abhijeet.kumar
2018-02-15 15:34 ` Applied "ASoC: hdac_hdmi : Ensuring proper setting of output widget power state" to the asoc tree Mark Brown
2018-02-15 16:56 ` [PATCH v2] ASoC: hdac_hdmi : Ensuring proper setting of output widget power state abhijeet.kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h373bpc4z.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=abhijeet.kumar@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guneshwor.o.singh@intel.com \
--cc=jeeja.kp@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeepx.tayal@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).