From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/2] sis7019: support the SiS 7019
	Audio	Accelerator
Date: Wed, 28 Nov 2007 13:36:21 +0100
Message-ID: <s5h3auqim2i.wl%tiwai@suse.de>
References: <1196234344.7017.31.camel@obelisk.thedillows.org>
	<s5hejeaithq.wl%tiwai@suse.de>
	<1196255015.7017.52.camel@obelisk.thedillows.org>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 2603A24B37
	for <alsa-devel@alsa-project.org>; Wed, 28 Nov 2007 14:11:07 +0100 (CET)
In-Reply-To: <1196255015.7017.52.camel@obelisk.thedillows.org>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Dave Dillow <dave@thedillows.org>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Wed, 28 Nov 2007 08:03:35 -0500,
Dave Dillow wrote:
> 
> > > +static struct snd_pcm_hardware sis_playback_hw_info = {
> > > +	.info = (SNDRV_PCM_INFO_MMAP |
> > > +		 SNDRV_PCM_INFO_MMAP_VALID |
> > > +		 SNDRV_PCM_INFO_INTERLEAVED |
> > > +		 SNDRV_PCM_INFO_BLOCK_TRANSFER |
> > > +		 SNDRV_PCM_INFO_SYNC_START |
> > > +		 SNDRV_PCM_INFO_RESUME),
> > 
> > SNDRV_PCM_INFO_SYNC_START seems invalid here.  It's not implemented in
> > the driver.
> 
> Perhaps I'm misunderstanding what SYNC_START is for -- I can start
> multiple playback/capture substreams at once in ->trigger(). If it means
> something else, can you point to a driver that does implement it
> properly so that I can see if can be implemented?

Sorry, looks like I typo'ed when I searched strngs (due to a damn
keyboard scan bug in the recent xorg...)
Please disregard my previous comment.

> > > +static void __sis_map_silence(struct sis7019 *sis)
> > 
> > Any reason to use __ prefix?
> 
> It requires locks to be held when it is called, making it an internal
> helper function. I'd prefer to keep the prefix, but it could go away, or
> be merged into the one call-site.

OK, then it's fine.  But add a proper comment.  Otherwise no one else
would understand the difference.


Thanks,

Takashi