From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [patch] Fix snd-usb-audio in 32-bit compat environemt
Date: Mon, 20 Feb 2006 12:09:08 +0100
Message-ID: <s5h3bie2sob.wl%tiwai@suse.de>
References: <878xs85wn6.fsf@blackdown.de>
	<20060219175646.GB7797@mipter.zuzino.mipt.ru>
	<87hd6vw4t0.fsf@blackdown.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S932439AbWBTLJL@vger.kernel.org>
In-Reply-To: <87hd6vw4t0.fsf@blackdown.de>
Sender: linux-kernel-owner@vger.kernel.org
To: Juergen Kreileder <jk@blackdown.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, alsa-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

At Sun, 19 Feb 2006 20:02:03 +0100,
Juergen Kreileder wrote:
> 
> Alexey Dobriyan <adobriyan@gmail.com> writes:
> 
> > On Sat, Feb 18, 2006 at 07:50:37PM +0100, Juergen Kreileder wrote:
> >> I'm getting oopses with snd-usb-audio in 32-bit compat
> >> environments: control_compat.c:get_ctl_type() doesn't initialize
> >> 'info', so
> >> 'itemlist[uinfo->value.enumerated.item]' in
> >> usbmixer.c:mixer_ctl_selector_info() might access random memory
> >> (The 'if ((int)uinfo->value.enumerated.item >= cval->max)' doesn't fix
> >> all problems because of the unsigned -> signed conversion.)
> >
> > IMO, what you did is an overkill.
> 
> The advantage of the longer fix is reduced stack usage.

But it also introduces a kmalloc overhead.
Let's fix the problem first with a simpler patch.

> > Does this patch fixes your problem?
> 
> Yes but you can have that even simpler:
> 
> --- linux-mm-vanilla/sound/core/control_compat.c	2006-02-18 17:00:17.000000000 +0100
> +++ linux-mm/sound/core/control_compat.c	2006-02-19 19:41:51.000000000 +0100
> @@ -167,7 +167,7 @@ static int get_ctl_type(struct snd_card 
>  			int *countp)
>  {
>  	struct snd_kcontrol *kctl;
> -	struct snd_ctl_elem_info info;
> +	struct snd_ctl_elem_info info = {0};
>  	int err;
>  
>  	down_read(&card->controls_rwsem);

I prefer Alexey's patch sicne it's clearer that the
zero-initialization is done just before the usage.

But = {0} might result in a better code because of compiler
optimization...


Thanks!

Takashi