From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D816AC433DF for ; Sat, 22 Aug 2020 16:18:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89C042072D for ; Sat, 22 Aug 2020 16:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="YAWMp6qV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89C042072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 11676844; Sat, 22 Aug 2020 18:17:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 11676844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598113116; bh=j3837Fj+btZAvZNuk4TiOMcAyfqWU5ZB0JmFObMsi/o=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YAWMp6qVDxRAgu3lBDC2vCLhP+bLmDfbV9JrvZ0QaGAStypVB4AoI0e5kDz8x76Ah q7tVAz8jbvFPutZfPU51ofHwzujpM4+T0Ywp7qJ2zx9utAKO22P2QBc2EZ+W8MoMLJ gflZRzSbeJ5rsjXMQQmAiko7UicZPZwA7pClGPak= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9D2F1F801ED; Sat, 22 Aug 2020 18:17:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0CD60F801F9; Sat, 22 Aug 2020 18:17:44 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 84F98F800C0 for ; Sat, 22 Aug 2020 18:17:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 84F98F800C0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DC0BEAFF2; Sat, 22 Aug 2020 16:18:09 +0000 (UTC) Date: Sat, 22 Aug 2020 18:17:41 +0200 Message-ID: From: Takashi Iwai To: Connor McAdams Subject: Re: [PATCH 05/20] ALSA: hda/ca0132 - Add bass redirection controls. In-Reply-To: <20200821185239.26133-6-conmanx360@gmail.com> References: <20200821185239.26133-1-conmanx360@gmail.com> <20200821185239.26133-6-conmanx360@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 21 Aug 2020 20:52:22 +0200, Connor McAdams wrote: > > +static int ca0132_alt_add_bass_redirection_crossover(struct hda_codec *codec) > +{ > + const char *namestr = "Output: Bass Redirection Playback Volume"; > + struct snd_kcontrol_new knew = > + HDA_CODEC_VOLUME_MONO(namestr, BASS_REDIRECTION_XOVER, 1, 0, > + HDA_OUTPUT); This is no ideal name string for a control element, too. Better to omit "Output:" prefix at least. thanks, Takashi