From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F64C54FCB for ; Thu, 23 Apr 2020 12:25:54 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F27062076C for ; Thu, 23 Apr 2020 12:25:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="F227hZrl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F27062076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3FFE8168F; Thu, 23 Apr 2020 14:25:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3FFE8168F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587644752; bh=h72wOO6Cc6Z5MTc/wObVKUKg1Fh/IE7Srlc1ycm0q0Y=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=F227hZrlAxCDUeAzkcn2u8L+J4zca+KosYA4NgP7OaymIiHhhXoIu2LXypj0getel HFbSwHxbssSewbht1QiVeaJ+Epd4Tdyvu+d4RGjHBDtB6JYGHRkmVNRmpqOMVQ8Jrm iUhp2zvpothXUiDdryjFee2g0aHXlJcaLhbr/cmg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A35A7F8014A; Thu, 23 Apr 2020 14:25:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 45F64F801EC; Thu, 23 Apr 2020 14:25:00 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ED8F4F80121 for ; Thu, 23 Apr 2020 14:24:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ED8F4F80121 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CE7BEABE2; Thu, 23 Apr 2020 12:24:52 +0000 (UTC) Date: Thu, 23 Apr 2020 14:24:53 +0200 Message-ID: From: Takashi Iwai To: Cezary Rojewski Subject: Re: [PATCH] ALSA: hda: Refactor Intel NHLT init In-Reply-To: <57dca563-b79c-3721-0057-22057db0e5a9@intel.com> References: <20200423112136.25207-1-cezary.rojewski@intel.com> <57dca563-b79c-3721-0057-22057db0e5a9@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com, pierre-louis.bossart@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 23 Apr 2020 14:21:15 +0200, Cezary Rojewski wrote: > > On 2020-04-23 14:15, Takashi Iwai wrote: > > On Thu, 23 Apr 2020 13:40:10 +0200, > > Cezary Rojewski wrote: > >> > >> On 2020-04-23 13:24, Takashi Iwai wrote: > >>> On Thu, 23 Apr 2020 13:21:36 +0200, > >>> Cezary Rojewski wrote: > >>>> > >>>> NHLT fetch based on _DSM prevents ACPI table override mechanism from > >>>> being utilized. Make use of acpi_get_table to enable it and get rid of > >>>> redundant code. > >>>> > >>>> Signed-off-by: Cezary Rojewski > >>> > >>> This looks like a nice cleanup and I'll happily apply if anyone can > >>> test with the actual hardware -- currently mine has no DSP, so unable > >>> to check. > >>> > >>> > >>> thanks, > >>> > >>> Takashi > >>> > >> > >> NHLT override method has been added for internal use half a year ago > >> and is for some time the default method within our CI. This is tested > >> on a wide spread of hardware, that is any Intel AVS archtecture, > >> including production laptops. > > > > This could be mentioned in the changelog, otherwise we have no idea > > about the test coverage. > > > > My apologizes Takashi, indeed I should have mentioned that :( > > I've forgotten about one more positive news: > https://bugs.acpica.org/show_bug.cgi?id=1525 > > Robert is working on official NHLT support for iASL. Currently, only > header gets decompilled while the rest is dumped as binary array. > > Do you want me to resubmit the patch with this entire info appended to > the commit message? Yes, it would be appreciated. Especially the additional information is helpful. thanks, Takashi