From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3531FC2D0C6 for ; Sat, 28 Dec 2019 08:06:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 452D8207E0 for ; Sat, 28 Dec 2019 08:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MR6tBOTR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 452D8207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 055BE1747; Sat, 28 Dec 2019 09:05:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 055BE1747 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1577520361; bh=oAEcd3iHVOkGDseM356oOVVfoy3nBoRaxOwfCq6u3zo=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MR6tBOTRrgCksleAflSTrlM2AV7Q9PqRx4SDXoDtzL7DQu2vsolwC7dlpcGjOKFTn fV31JPjgaeGQCHlzMUDikT9mkeSz+rYCjhmMwm0nP4JJZQ2NfqGZXcHm2JkzT3CLzH tR9xekul1x5WuF1snth10R1r+tEtun34CJMwQXdg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 86A7FF80138; Sat, 28 Dec 2019 09:05:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0082FF80139; Sat, 28 Dec 2019 09:05:08 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 474A3F800AE for ; Sat, 28 Dec 2019 09:05:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 474A3F800AE X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7C099ABF4; Sat, 28 Dec 2019 08:05:04 +0000 (UTC) Date: Sat, 28 Dec 2019 09:05:02 +0100 Message-ID: From: Takashi Iwai To: Chris Chiu In-Reply-To: <20191227100825.75790-1-chiu@endlessm.com> References: <20191227100825.75790-1-chiu@endlessm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, kailang@realtek.com, tomas.espeleta@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, hui.wang@canonical.com, Jian-Hong Pan , linux@endlessm.com Subject: Re: [alsa-devel] [PATCH v2] ALSA: hda/realtek - Enable the bass speaker of ASUS UX431FLC X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 27 Dec 2019 11:08:25 +0100, Chris Chiu wrote: > > ASUS reported that there's an bass speaker in addition to internal > speaker and it uses DAC 0x02. It was not enabled in the commit > 436e25505f34 ("ALSA: hda/realtek - Enable internal speaker of ASUS > UX431FLC") which only enables the amplifier for the front speaker. > This commit enables the bass speaker on top of the aforementioned > work to improve the acoustic experience. > > Signed-off-by: Chris Chiu > Signed-off-by: Jian-Hong Pan > --- > > Notes: > v2: > - Use existing alc285_fixup_speaker2_to_dac1 instead of new fixup function > - Correct the commit hash number in the commit message > - Remove the redundant fixup ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC Could you rebase on the latest for-linus branch? This patch isn't applied cleanly any longer. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel