From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - Disable Headphone Mic boost for ALC662 Date: Thu, 28 May 2015 09:18:40 +0200 Message-ID: References: <1432797346-2742-1-git-send-email-david.henningsson@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6C47426044F for ; Thu, 28 May 2015 09:18:40 +0200 (CEST) In-Reply-To: <1432797346-2742-1-git-send-email-david.henningsson@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: alsa-devel@alsa-project.org, 14545235@bugs.launchpad.net List-Id: alsa-devel@alsa-project.org At Thu, 28 May 2015 09:15:46 +0200, David Henningsson wrote: > > When headphone mic boost is above zero, some 10 - 20 second delay > might occur before the headphone mic is operational. > Therefore disable the headphone mic boost control (recording gain is > sufficient even without it). > > (Note: this patch is not about the headset mic, it's about the less > common mic-in only mode.) > > BugLink: https://bugs.launchpad.net/bugs/1454235 > Suggested-by: Kailang Yang > Signed-off-by: David Henningsson > --- > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index d0fa455..87605fc 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -4240,6 +4240,10 @@ static void alc_fixup_headset_mode_alc662(struct hda_codec *codec, > if (action == HDA_FIXUP_ACT_PRE_PROBE) { > spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; > spec->gen.hp_mic = 1; /* Mic-in is same pin as headphone */ > + > + /* Disable boost for mic-in permanently */ > + snd_hda_codec_write(codec, 0x1b, 0, AC_VERB_SET_AMP_GAIN_MUTE, 0x7000); > + snd_hda_override_wcaps(codec, 0x1b, get_wcaps(codec, 0x1b) & ~AC_WCAP_IN_AMP); Can we really hard-code NID 0x1b here...? Takashi