From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 41/45] include/uapi/sound/emu10k1.h: hide gpr_valid, tram_valid and code_valid in userspace Date: Wed, 11 Mar 2015 07:11:18 +0100 Message-ID: References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-42-git-send-email-mikko.rapeli@iki.fi> <20150311012204.GE12550@lakka.kapsi.fi> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150311012204.GE12550-dqH1CgrzRhOk/eJAJmRu5A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mikko Rapeli Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jaroslav Kysela , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: alsa-devel@alsa-project.org At Wed, 11 Mar 2015 03:22:04 +0200, Mikko Rapeli wrote: >=20 > On Tue, Feb 17, 2015 at 07:27:38AM +0100, Takashi Iwai wrote: > > At Tue, 17 Feb 2015 00:05:44 +0100, > > Mikko Rapeli wrote: > > >=20 > > > The DECLARE_BITMAP macro is not available in userspace headers. > > > Fixes userspace compile error: > > > error: expected specifier-qualifier-list before =E2=80=98DECLARE_= BITMAP=E2=80=99 > >=20 > > It's nonsense. This results in an incompatible structure, thus ABI > > would be broken completely (actually this will break the compile of > > ld10k1). >=20 > None of the exported headers after 'make headers_install' have defini= tion > of DECLARE_BITMAP macro. It is defined in include/linux/types.h which= is > different from include/uapi/linux/types.h and missing this definition= and > a few other things. >=20 > One option would be add DECLARE_BITMAP macro to include/uapi/linux/ty= pes.h > and add include/linux/bitops.h to uapi. >=20 > Thoughts? Are there any other headers like that? If this is the only one, leave it as is. The only program that reads this are some alsa-tools ones and they have already own DECLARE_BITMAP() definition. Adding the extra definition here will even break the compilation out of sudden. Takashi