From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E917CC433DF for ; Tue, 7 Jul 2020 08:14:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74952206C3 for ; Tue, 7 Jul 2020 08:14:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ii8UPOfD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74952206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D984D1663; Tue, 7 Jul 2020 10:13:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D984D1663 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594109667; bh=uMA8Jpn2zsKQZEDdNquivF4VvLnEXqulhKfBX5eMUWM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ii8UPOfDGv0nr5LcStNqFjeYQdgN17P9YAS1HrEzeG+B8jR3fDNu6wYCyni1eWGQk QdybEqn/9c0uiuInrmQ9WT0TY/00rzrl5D6GFlJbhvX+bTLxG02PIQg8p5gWx2baJs RMJ855tB3hWHQBN4gCwUWuGFnkBSr87dJRuPfm9E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6F20DF801F9; Tue, 7 Jul 2020 10:13:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0F600F80216; Tue, 7 Jul 2020 10:13:36 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 24398F800D0 for ; Tue, 7 Jul 2020 10:13:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 24398F800D0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A4D0CAF3B; Tue, 7 Jul 2020 08:13:29 +0000 (UTC) Date: Tue, 07 Jul 2020 10:13:29 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH 1/2] ALSA: hda/hdmi: fix failures at PCM open on Intel ICL and later In-Reply-To: <20200703153818.2808592-1-kai.vehmanen@linux.intel.com> References: <20200703153818.2808592-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, libin.yang@linux.intel.com, Ranjani Sridharan X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 03 Jul 2020 17:38:17 +0200, Kai Vehmanen wrote: > > When HDMI PCM devices are opened in a specific order, with at least one > HDMI/DP receiver connected, ALSA PCM open fails to -EBUSY on the > connected monitor, on recent Intel platforms (ICL/JSL and newer). While > this is not a typical sequence, at least Pulseaudio does this every time > when it is started, to discover the available PCMs. > > The rootcause is an invalid assumption in hdmi_add_pin(), where the > total number of converters is assumed to be known at the time the > function is called. On older Intel platforms this held true, but after > ICL/JSL, the order how pins and converters are in the subnode list as > returned by snd_hda_get_sub_nodes(), was changed. As a result, > information for some converters was not stored to per_pin->mux_nids. > And this means some pins cannot be connected to all converters, and > application instead gets -EBUSY instead at open. > > The assumption that converters are always before pins in the subnode > list, is not really a valid one. Fix the problem in hdmi_parse_codec() > by introducing separate loops for discovering converters and pins. > > BugLink: https://github.com/thesofproject/linux/issues/1978 > BugLink: https://github.com/thesofproject/linux/issues/2216 > BugLink: https://github.com/thesofproject/linux/issues/2217 > Reviewed-by: Ranjani Sridharan > Reviewed-by: Pierre-Louis Bossart > Signed-off-by: Kai Vehmanen Thanks, applied. Takashi