From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] Support for Yamaha MOXF
Date: Thu, 09 Jan 2014 07:38:07 +0100
Message-ID: <s5h61ptpsmo.wl%tiwai@suse.de>
References: <52CE2EF6.7010902@knobbits.org>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 8E627265230
 for <alsa-devel@alsa-project.org>; Thu,  9 Jan 2014 07:38:07 +0100 (CET)
In-Reply-To: <52CE2EF6.7010902@knobbits.org>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Michael Slade <mslade@knobbits.org>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Thu, 09 Jan 2014 16:09:10 +1100,
Michael Slade wrote:
> 
> My apologies if I'm doing this wrong.
> 
> I have managed to get a Yamaha MOXF8 working with the attached patch.  
> Presumably also works with a MOXF6.
> 
> The new Yamaha MOXF6/8 are successors to the MOX6/8.  Apart from things 
> like new voices, a flash expansion port, and a different colour at the 
> ends, they are pretty much identical in operation.
> 
> The MOXF has a USB ID of 0499:150f.  So I needed to add a new 
> quirks-table.h stanza for it, by copy-pasting the MOX one and changing 
> he ID.
> 
> I haven't tested it to death or anything,  but I am having no trouble 
> recording and playing audio and midi.
> 
> Let me know if this patch is acceptable or of there is more that is 
> needed from me.
> 
> Note, this patch is against Ubuntu Raring's 3.8.0 kernel, but it's a 
> trivial patch.

The code change looks OK, but please reformat the patch in the way to
follow Documentation/SubmittigPatches and resubmit to ML.


thanks,

Takashi

> 
> Mick.
> 
> [2 alsa-yamaha-moxf.patch <text/x-patch (7bit)>]
> --- linux-3.8.0.orig/sound/usb/quirks-table.h
> +++ linux-3.8.0/sound/usb/quirks-table.h
> @@ -353,6 +359,32 @@
>  		}
>  	}
>  },
> +{
> +	USB_DEVICE(0x0499, 0x150f),
> +	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
> +		/* .vendor_name = "Yamaha", */
> +		/* .product_name = "MOXF6/MOXF8", */
> +		.ifnum = QUIRK_ANY_INTERFACE,
> +		.type = QUIRK_COMPOSITE,
> +		.data = (const struct snd_usb_audio_quirk[]) {
> +			{
> +				.ifnum = 1,
> +				.type = QUIRK_AUDIO_STANDARD_INTERFACE
> +			},
> +			{
> +				.ifnum = 2,
> +				.type = QUIRK_AUDIO_STANDARD_INTERFACE
> +			},
> +			{
> +				.ifnum = 3,
> +				.type = QUIRK_MIDI_YAMAHA
> +			},
> +			{
> +				.ifnum = -1
> +			}
> +		}
> +	}
> +},
>  YAMAHA_DEVICE(0x2000, "DGP-7"),
>  YAMAHA_DEVICE(0x2001, "DGP-5"),
>  YAMAHA_DEVICE(0x2002, NULL),
> [3  <text/plain; us-ascii (7bit)>]
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel