From: Takashi Iwai <tiwai@suse.de>
To: Joe Perches <joe@perches.com>
Cc: alsa-devel@alsa-project.org, Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/14] sound/ppc: Use printf extension %pR for struct resource
Date: Mon, 22 Nov 2010 07:44:04 +0100 [thread overview]
Message-ID: <s5h62vpsvrf.wl%tiwai@suse.de> (raw)
In-Reply-To: <434a77317cc09300e79b7768170eec7ae04adb92.1289597644.git.joe@perches.com>
At Fri, 12 Nov 2010 13:38:04 -0800,
Joe Perches wrote:
>
> Using %pR standardizes the struct resource output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied now. Thanks.
Takashi
> ---
> sound/ppc/pmac.c | 12 ++++--------
> 1 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
> index 8508117..b47cfd4 100644
> --- a/sound/ppc/pmac.c
> +++ b/sound/ppc/pmac.c
> @@ -1228,10 +1228,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return)
> chip->rsrc[i].start + 1,
> rnames[i]) == NULL) {
> printk(KERN_ERR "snd: can't request rsrc "
> - " %d (%s: 0x%016llx:%016llx)\n",
> - i, rnames[i],
> - (unsigned long long)chip->rsrc[i].start,
> - (unsigned long long)chip->rsrc[i].end);
> + " %d (%s: %pR)\n",
> + i, rnames[i], &chip->rsrc[i]);
> err = -ENODEV;
> goto __error;
> }
> @@ -1256,10 +1254,8 @@ int __devinit snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return)
> chip->rsrc[i].start + 1,
> rnames[i]) == NULL) {
> printk(KERN_ERR "snd: can't request rsrc "
> - " %d (%s: 0x%016llx:%016llx)\n",
> - i, rnames[i],
> - (unsigned long long)chip->rsrc[i].start,
> - (unsigned long long)chip->rsrc[i].end);
> + " %d (%s: %pR)\n",
> + i, rnames[i], &chip->rsrc[i]);
> err = -ENODEV;
> goto __error;
> }
> --
> 1.7.3.1.g432b3.dirty
>
prev parent reply other threads:[~2010-11-22 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 21:37 [PATCH 00/14] Use printf extension %pR for struct resource Joe Perches
2010-11-12 21:38 ` [PATCH 14/14] sound/ppc: " Joe Perches
2010-11-22 6:44 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h62vpsvrf.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).