From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] mpu401.c: Buffer overflow
Date: Wed, 29 Jul 2009 14:44:34 +0200
Message-ID: <s5h63dbwte5.wl%tiwai@suse.de>
References: <4A702079.4080304@gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id E5891103814
	for <alsa-devel@alsa-project.org>;
	Wed, 29 Jul 2009 14:44:36 +0200 (CEST)
In-Reply-To: <4A702079.4080304@gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Roel Kluin <roel.kluin@gmail.com>
Cc: alsa-devel@alsa-project.org, Andrew Morton <akpm@linux-foundation.org>
List-Id: alsa-devel@alsa-project.org

At Wed, 29 Jul 2009 12:12:09 +0200,
Roel Kluin wrote:
> 
> mpu_synth_info[m].name is a char[30], and the minimum length of the data
> written by sprintf is 31 bytes including terminating null.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Applied now.  Thanks.


Takashi

> ---
> Found with Parfait, http://research.sun.com/projects/parfait/
> 
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 1b2316f..734b8f9 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -1074,7 +1074,7 @@ int attach_mpu401(struct address_info *hw_config, struct module *owner)
>  			sprintf(mpu_synth_info[m].name, "%s (MPU401)", hw_config->name);
>  		else
>  			sprintf(mpu_synth_info[m].name,
> -				"MPU-401 %d.%d%c Midi interface #%d",
> +				"MPU-401 %d.%d%c MIDI #%d",
>  				(int) (devc->version & 0xf0) >> 4,
>  				devc->version & 0x0f,
>  				revision_char,
>