Re: [PATCH] ASoC TLV320AIC3X codec driver

[Takashi Iwai <tiwai@suse.de>]

At Wed, 14 Nov 2007 16:04:31 +0300,
Vladimir A. Barinov wrote:
> 
> >> +/*
> >> + * All input lines are connected when !0xf and disconnected with 0xf bit field,
> >>     
> >
> > Please keep the line within 80 chars.  Try to run checkpatch.pl in
> > linuxkernel/scripts for checking such minor coding-style issues.
> >   
> But this line is less then 80 chars :)

Ah, ok, maybe my editor window was too narrow.  Please disregard it.

> >> +#define AIC3X_RATES	SNDRV_PCM_RATE_8000_96000
> >> +#define AIC3X_FORMATS	(SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
> >> +			 SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
> >>     
> >
> > Are you sure that it's FMTBIT_S24_LE?  It's not packed in 3 bytes but
> > uses lower 3 bytes of 4 bytes frame.
> >
> >   
> Aic3x supports 16/20/24/32 bits data word length and in accordance with 
> aic33 documentation the
> number of clocks per half-frame for each channel are equal to exact 
> number of bits of the word.
> Unfortunately, now I have no h/w to test 24bits mode.

Then it sounds like the correct data format is FMTBIT_S24_3LE instead
of FMTBIT_S24_LE.  The former is 3-byte format while the latter is
4-byte.  Please check again.


thanks,

Takashi