From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57293C433EF for ; Wed, 27 Oct 2021 06:24:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E86C2610A0 for ; Wed, 27 Oct 2021 06:24:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E86C2610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9AD6416CF; Wed, 27 Oct 2021 08:24:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9AD6416CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635315893; bh=+Zsgg68dtrM4YjODbLjWCUSrP04Xsz5iyDRe1GH6M8k=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AuV1LDcxmSdXC+3+/2eDkfKemh6PMCT4/bhLoT6SdllnZYGOAtzmyLLblJtbg9rGA jovttHslg41yY3T/0oZMVU91Hcij3PAIUHOmm5u7b/zthZBp6Q4i9KI8VDyyAf6UeT D9jukf1VgFdKZ4rFA6CEtK+7Phef9zt4fQiISOHc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3ED8AF8016C; Wed, 27 Oct 2021 08:24:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B890DF8025A; Wed, 27 Oct 2021 08:24:01 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 145D2F800D1 for ; Wed, 27 Oct 2021 08:23:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 145D2F800D1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="HjL3NWIt"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="87RWXEyS" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 9341B1FD47; Wed, 27 Oct 2021 06:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1635315836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ua2RExmAJ4Oar37g/9kkjA5B9D0zknkT1W1DLUdKtBM=; b=HjL3NWItkFHCKayxxs+U+EBdLODYLkZ9H4E8ixvmJgbs9+akqz7QyYghW438CWKxNVPxFN b/dPfc/TwNA44/Os1cwQLGwOGMiuKSdtPpHr7dN3qBRZ6e/MYaVtTepaP5jxfFaZBqdNiZ txx8NmpaOQWxuG6qNxvKv2eHQgyqdVk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1635315836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ua2RExmAJ4Oar37g/9kkjA5B9D0zknkT1W1DLUdKtBM=; b=87RWXEySjuuV1rfZGI1en85DOa9KoUPwsd3fTNMkQ7tCxyYi+sQ5C24i5BY4lgujeBqRUU wQ4izBLJJo8TZtAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 67326A3B81; Wed, 27 Oct 2021 06:23:56 +0000 (UTC) Date: Wed, 27 Oct 2021 08:23:56 +0200 Message-ID: From: Takashi Iwai To: Johan Hovold Subject: Re: [PATCH] sound: ua101: fix division by zero at probe In-Reply-To: <20211026095401.26522-1-johan@kernel.org> References: <20211026095401.26522-1-johan@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, Clemens Ladisch , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 26 Oct 2021 11:54:01 +0200, Johan Hovold wrote: > > Add the missing endpoint max-packet sanity check to probe() to avoid > division by zero in alloc_stream_buffers() in case a malicious device > has broken descriptors (or when doing descriptor fuzz testing). > > Note that USB core will reject URBs submitted for endpoints with zero > wMaxPacketSize but that drivers doing packet-size calculations still > need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip > endpoint descriptors with maxpacket=0")). > > Fixes: 63978ab3e3e9 ("sound: add Edirol UA-101 support") > Cc: stable@vger.kernel.org # 2.6.34 > Signed-off-by: Johan Hovold Thanks, applied. Takashi