From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D660C433E0 for ; Tue, 7 Jul 2020 10:36:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03704206E2 for ; Tue, 7 Jul 2020 10:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="LoIPFs0n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03704206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8550C1687; Tue, 7 Jul 2020 12:35:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8550C1687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594118164; bh=Lm71E/+tG+oBf9vubesfWFwcTi1+FjwgYJJzBS9oGtY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LoIPFs0nDyT9GmtG/pDeCEWR9Ilg4RkD3R5P7sgAmpKV7+hhrTF1awtABe01UIrSb Dzy9JdXttaN+/4hfNyFYgylJEqww686J2ZR8iuFNigeUSP8i8RZe1RbrNXo2+HuxyS DwrZFcqnUl7/buxkwEPapVDEQ9osKA3XpLp59OyA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B7AF3F80274; Tue, 7 Jul 2020 12:22:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2EEB8F802A9; Tue, 7 Jul 2020 12:22:04 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6FABBF80264 for ; Tue, 7 Jul 2020 12:21:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6FABBF80264 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3DBF8B049; Tue, 7 Jul 2020 10:21:54 +0000 (UTC) Date: Tue, 07 Jul 2020 12:21:53 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [RFC PATCH 00/23] ALSA: fix kernel-doc and W=1 warnings In-Reply-To: <20200702193604.169059-1-pierre-louis.bossart@linux.intel.com> References: <20200702193604.169059-1-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 02 Jul 2020 21:35:41 +0200, Pierre-Louis Bossart wrote: > > This cleanup touches a lot of old - and very old code for hardware > designed in the late 1990s/early 2000s -, hence the RFC status. I > mostly did dumb edits just to make warnings go away, suggestions and > feedback welcome. > > Pierre-Louis Bossart (23): > ALSA: isa/gus: remove -Wmissing-prototypes warnings > ALSA: isa/gus: remove 'set but not used' warning > ALSA: pci/asihpi: remove 'set but not used' warnings > ALSA: pci/asihpi: fix kernel-doc > ALSA: pci/asihpi: remove 'set but not used' warning > ALSA: pci/echoaudio: remove 'set but not used' warning > ALSA: pci/aw2-saa7146: remove 'set but not used' warning > ALSA: pci/ctxfi/ctatc: fix kernel-doc > ALSA: pci/ctxfi: fix kernel-doc warnings > ALSA: usb/line6: remove 'defined but not used' warning > ASoC: pci/emu10k1: remove "set but not used' warnings > ALSA: firewire: fix kernel-doc > ALSA: pci/emu10k1: remove 'set but not used' warning > ALSA: pci/korg1212: remove 'set but not used' warnings > ALSA: pci/rme9652/hdspm: remove always true condition > ALSA: pci/oxygen/xonar_wm87x6: remove always true condition > ALSA: xen: remove 'set but not used' warning > ALSA: pci/es1938: remove 'set but not used' warning > ALSA: pci/fm801: fix kernel-doc > ALSA: pci/via82xx: remove 'set but not used' warnings > ALSA: pcmcia/pdaudiocf: fix kernel-doc > ALSA: vx_core: remove warning for empty loop body > ALSA: pci/au88x0: remove "defined but not used" warnings Those look OK although __maybe_unused and __always_unused aren't always intuitive. At least better than spewing the warnings unnecessarily. The line6 patch hasn't been applied yet because it might be clearer to be replaced with define instead. A similar argument may be applied to au88x0 code, but this is much uglier and I'd take a more straightforward fix by your patch. So, now all but patch#10 are applied to for-next branch. Thanks! Takashi