From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBDD9C55186 for ; Thu, 23 Apr 2020 12:16:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B9D72098B for ; Thu, 23 Apr 2020 12:16:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MXvibJ7a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B9D72098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9ABB1168F; Thu, 23 Apr 2020 14:15:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9ABB1168F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587644177; bh=H6MJoGnzGL3rCvJnKGQ0BGa13WPTfl+dPvDjxpY7zOM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MXvibJ7aLoF1SKLK/LDIKBpV3Hhmd0C4ZtM+oIGNmpszTFoNBC36PcUY/rG05viDT hwHGZQ660G2RmvXtBcYziZXadCw7ZsmAogzyO+cVuqOGJ6OOJQIkKSjeSOGdS07ody pGITjtYwcUJmqH8drlNZFtCG2GFI2Z8t19sNTZCk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2E687F8014A; Thu, 23 Apr 2020 14:15:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8B38DF801EC; Thu, 23 Apr 2020 14:15:26 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 35573F80121 for ; Thu, 23 Apr 2020 14:15:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 35573F80121 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 765CDB13C; Thu, 23 Apr 2020 12:15:18 +0000 (UTC) Date: Thu, 23 Apr 2020 14:15:18 +0200 Message-ID: From: Takashi Iwai To: Cezary Rojewski Subject: Re: [PATCH] ALSA: hda: Refactor Intel NHLT init In-Reply-To: References: <20200423112136.25207-1-cezary.rojewski@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com, pierre-louis.bossart@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 23 Apr 2020 13:40:10 +0200, Cezary Rojewski wrote: > > On 2020-04-23 13:24, Takashi Iwai wrote: > > On Thu, 23 Apr 2020 13:21:36 +0200, > > Cezary Rojewski wrote: > >> > >> NHLT fetch based on _DSM prevents ACPI table override mechanism from > >> being utilized. Make use of acpi_get_table to enable it and get rid of > >> redundant code. > >> > >> Signed-off-by: Cezary Rojewski > > > > This looks like a nice cleanup and I'll happily apply if anyone can > > test with the actual hardware -- currently mine has no DSP, so unable > > to check. > > > > > > thanks, > > > > Takashi > > > > NHLT override method has been added for internal use half a year ago > and is for some time the default method within our CI. This is tested > on a wide spread of hardware, that is any Intel AVS archtecture, > including production laptops. This could be mentioned in the changelog, otherwise we have no idea about the test coverage. > Actual override works like any SSDT/ DSDT, e.g. usage can be found at: > https://github.com/thesofproject/acpi-scripts > > and original: > https://wiki.up-community.org/Pinout_UP2#Installing_ACPI_overrides_to_enable_spi_in_userspace > > Early this year I've pushed the initiative to finally shatter bounds > of mystery surrounding NHLT in Linux and make it available to > community. Erik and Robert helped me in ACPICA part, patch link: > https://patchwork.kernel.org/patch/11463235/ > > Spec can now be found at: > https://01.org/blogs/intel-smart-sound-technology-audio-dsp > > This has been sanctioned by Intel Legal and acked by Marcin Obara, > NHLT author so no worries about spec disappearing like it did in 2016. Great, thanks! Takashi