Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vkoul@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org,
	Banajit Goswami <bgoswami@codeaurora.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-msm@vger.kernel.org, Patrick Lai <plai@codeaurora.org>,
	Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [RFC PATCH 0/3] ALSA: compress: Add support for FLAC
Date: Fri, 15 Nov 2019 14:21:50 +0100	[thread overview]
Message-ID: <s5h7e41jmvl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191115102705.649976-1-vkoul@kernel.org>

On Fri, 15 Nov 2019 11:27:02 +0100,
Vinod Koul wrote:
> 
> The current design of sending codec parameters assumes that decoders
> will have parsers so they can parse the encoded stream for parameters
> and configure the decoder.
> 
> But this assumption may not be universally true and we know some DSPs
> which do not contain the parsers so additional parameters are required
> to be passed.
> 
> So add these parameters starting with FLAC decoder. The size of
> snd_codec_options is still 120 bytes after this change (due to this
> being a union)
> 
> I think we should also bump the (minor) version if this proposal is
> acceptable so the userspace can check and populate flac specific structure.
> 
> Along, with the core header change, patches are added to support FLAC
> in Qualcomm drivers. This was tested on 96boards db845c
> 
> Srinivas Kandagatla (1):
>   ASoC: qcom: q6asm: add support to flac config
> 
> Vinod Koul (2):
>   ALSA: compress: add flac decoder params
>   ASoC: qcom: q6asm-dai: add support to flac decoder

Feel free to take my ACK for ALSA core part:
  Acked-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-11-15 13:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 10:27 [alsa-devel] [RFC PATCH 0/3] ALSA: compress: Add support for FLAC Vinod Koul
2019-11-15 10:27 ` [alsa-devel] [RFC PATCH 1/3] ALSA: compress: add flac decoder params Vinod Koul
2019-11-18 13:00   ` [alsa-devel] Applied "ALSA: compress: add flac decoder params" to the asoc tree Mark Brown
2019-11-15 10:27 ` [alsa-devel] [RFC PATCH 2/3] ASoC: qcom: q6asm: add support to flac config Vinod Koul
2019-11-18 13:00   ` [alsa-devel] Applied "ASoC: qcom: q6asm: add support to flac config" to the asoc tree Mark Brown
2019-11-15 10:27 ` [alsa-devel] [RFC PATCH 3/3] ASoC: qcom: q6asm-dai: add support to flac decoder Vinod Koul
2019-11-18 13:00   ` [alsa-devel] Applied "ASoC: qcom: q6asm-dai: add support to flac decoder" to the asoc tree Mark Brown
2019-11-15 13:21 ` Takashi Iwai [this message]
2019-11-15 13:36   ` [alsa-devel] [RFC PATCH 0/3] ALSA: compress: Add support for FLAC Vinod Koul
2019-11-15 14:55 ` Pierre-Louis Bossart
2019-11-19  4:15   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7e41jmvl.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=plai@codeaurora.org \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox