From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: kbuild-all@01.org, alsa-devel@alsa-project.org,
Dan Murphy <dmurphy@ti.com>, kbuild test robot <lkp@intel.com>
Subject: Re: [alsa-devel] [asoc:for-5.5 122/122] sound/soc/codecs/tas2562.c:195:14: sparse: sparse: restricted snd_pcm_format_t degrades to integer
Date: Tue, 22 Oct 2019 07:08:16 +0200 [thread overview]
Message-ID: <s5h7e4xe5a7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191021191913.GI4691@sirena.co.uk>
On Mon, 21 Oct 2019 21:19:13 +0200,
Mark Brown wrote:
>
> On Fri, Oct 11, 2019 at 07:13:38AM -0500, Dan Murphy wrote:
> > On 10/10/19 11:41 AM, kbuild test robot wrote:
>
> > > 190 static int tas2562_set_bitwidth(struct tas2562_data *tas2562, int bitwidth)
>
> > The only fix I can see here is to change bitwidth to snd_pcm_format_t as
>
> > But that still gives this sparse warning. The way the code below is
> > written to be consistent throughout the drivers so are these warnings false
> > positives?
>
> I think so, yes. Or at least I can't see any sensible way to stop this
> anyway.
You can pass the real bit width (16, 24, 32) via
snd_pcm_format_width().
BTW, the error message after tas2562_set_samplerate() seems bogus,
still indicating the bitwidth instead of the rate.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-10-22 5:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:41 [alsa-devel] [asoc:for-5.5 122/122] sound/soc/codecs/tas2562.c:195:14: sparse: sparse: restricted snd_pcm_format_t degrades to integer kbuild test robot
2019-10-11 12:13 ` Dan Murphy
2019-10-21 19:19 ` Mark Brown
2019-10-22 0:17 ` [alsa-devel] [kbuild-all] " Rong Chen
2019-10-22 5:08 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7e4xe5a7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox