From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FBEFA3735 for ; Thu, 17 Oct 2019 10:05:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3DC720869 for ; Thu, 17 Oct 2019 10:05:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="qXmyvzps" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3DC720869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7AA65850; Thu, 17 Oct 2019 12:04:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7AA65850 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571306719; bh=jWxmEaxig0P3hjVnMjgSGAl3QK2Vd2vWJlas5zzU7EI=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qXmyvzps7jB6asU6aeW0Ori8LsrOrEPJHeWK0syJ7yk5SAfG8LNmSmoMGoAQTWyd5 i+4ZWM8X8cfuS+vEw74r2FbduQXUOqPsikhdpoH+6N6Pn7MLjyf8f5GDTcHQMMTL28 4ZKGY06qp1MuJGo9NPKE8q4vu+qIfHq1Cbg6o42k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0D35CF804A9; Thu, 17 Oct 2019 12:04:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B172DF804AA; Thu, 17 Oct 2019 12:04:27 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 204E5F80322 for ; Thu, 17 Oct 2019 12:04:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 204E5F80322 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1C2B6B1EA; Thu, 17 Oct 2019 10:04:24 +0000 (UTC) Date: Thu, 17 Oct 2019 12:04:23 +0200 Message-ID: From: Takashi Iwai To: kbuild test robot In-Reply-To: <201910171743.2X4agjN2%lkp@intel.com> References: <201910171743.2X4agjN2%lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, Kai-Heng Feng , kbuild-all@lists.01.org Subject: Re: [alsa-devel] [sound:for-next 2/20] drivers/pci/pci.c:5859:6: error: redefinition of 'pci_pr3_present' X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 17 Oct 2019 11:42:47 +0200, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > head: fa5a68b2abcefe2204075c80662e02cf59567a9f > commit: 2e1a529c10e18e62da55eac42c278f11216dddaa [2/20] PCI: Add pci_pr3_present() helper to check Power Resource for D3hot > config: parisc-c3000_defconfig (attached as .config) > compiler: hppa-linux-gcc (GCC) 7.4.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 2e1a529c10e18e62da55eac42c278f11216dddaa > # save the attached .config to linux build tree > GCC_VERSION=7.4.0 make.cross ARCH=parisc > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > >> drivers/pci/pci.c:5859:6: error: redefinition of 'pci_pr3_present' > bool pci_pr3_present(struct pci_dev *pdev) > ^~~~~~~~~~~~~~~ > In file included from include/linux/of_pci.h:5:0, > from drivers/pci/pci.c:17: > include/linux/pci.h:2317:13: note: previous definition of 'pci_pr3_present' was here > static bool pci_pr3_present(struct pci_dev *pdev) { return false; } > ^~~~~~~~~~~~~~~ It looks like the ifdef CONFIG_ACPI is missing in pci_pr3_present() definition in pci.c. I drop the two patches for now. Kai-Heng, could you resubmit with the proper fix? thanks, Takashi > drivers/pci/pci.c: In function 'pci_pr3_present': > >> drivers/pci/pci.c:5870:13: error: dereferencing pointer to incomplete type 'struct acpi_device' > return adev->power.flags.power_resources && > ^~ > >> drivers/pci/pci.c:5871:3: error: implicit declaration of function 'acpi_has_method'; did you mean 'acpi_has_watchdog'? [-Werror=implicit-function-declaration] > acpi_has_method(adev->handle, "_PR3"); > ^~~~~~~~~~~~~~~ > acpi_has_watchdog > In file included from include/linux/of_pci.h:5:0, > from drivers/pci/pci.c:17: > At top level: > include/linux/pci.h:2317:13: warning: 'pci_pr3_present' defined but not used [-Wunused-function] > static bool pci_pr3_present(struct pci_dev *pdev) { return false; } > ^~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > vim +/pci_pr3_present +5859 drivers/pci/pci.c > > 5858 > > 5859 bool pci_pr3_present(struct pci_dev *pdev) > 5860 { > 5861 struct acpi_device *adev; > 5862 > 5863 if (acpi_disabled) > 5864 return false; > 5865 > 5866 adev = ACPI_COMPANION(&pdev->dev); > 5867 if (!adev) > 5868 return false; > 5869 > > 5870 return adev->power.flags.power_resources && > > 5871 acpi_has_method(adev->handle, "_PR3"); > 5872 } > 5873 EXPORT_SYMBOL_GPL(pci_pr3_present); > 5874 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel