From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h
Date: Fri, 09 Aug 2019 14:55:40 +0200
Message-ID: <s5h7e7mh50z.wl-tiwai@suse.de>
References: <20190809095550.71040-1-yuehaibing@huawei.com>
        <20190809110100.71236-1-yuehaibing@huawei.com>
        <s5ha7cih53w.wl-tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <s5ha7cih53w.wl-tiwai@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
To: broonie@kernel.org
Cc: YueHaibing <yuehaibing@huawei.com>, lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com, yang.jie@linux.intel.com, perex@perex.cz, Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

On Fri, 09 Aug 2019 14:53:55 +0200,
Takashi Iwai wrote:
> 
> On Fri, 09 Aug 2019 13:01:00 +0200,
> YueHaibing wrote:
> > 
> > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails:
> > 
> > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init:
> > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function
> >  snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration]
> >  #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops()
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Suggested-by: Takashi Iwai <tiwai@suse.de>
> > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly")
>                        ^
> Use " consistently for both opening and closing quotes.
> 
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Reviewed-by: Takashi Iwai <tiwai@suse.de>

Actually I'm going to take this again on top of
topic/hda-bus-ops-cleanup branch of my tree, so Mark, feel free to
pull onto yours again.

Sorry for the mess!


Takashi