From: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] topology: delete output file if parsing fails.
Date: Sat, 10 Jun 2017 11:35:46 +0200 [thread overview]
Message-ID: <s5h7f0k2nil.wl-tiwai@suse.de> (raw)
In-Reply-To: <1497022422-5974-1-git-send-email-liam.r.girdwood@linux.intel.com>
On Fri, 09 Jun 2017 17:33:42 +0200,
Liam Girdwood wrote:
>
> Currently the binary output file is left when parsing fails. This confuses
> GNU Make if the parsing fails and causes the compilation to partially
> complete.
>
> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Applied, thanks.
But at the next time, please specify which repo to apply.
It took some time until I figured out it's for alsa-utils.
Takashi
> ---
> topology/topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/topology/topology.c b/topology/topology.c
> index 6d876ee..097c255 100644
> --- a/topology/topology.c
> +++ b/topology/topology.c
> @@ -108,6 +108,7 @@ int main(int argc, char *argv[])
> if (err < 0) {
> fprintf(stderr, _("failed to compile context %s\n"), source_file);
> snd_tplg_free(snd_tplg);
> + unlink(output_file);
> return 1;
> }
>
> --
> 2.11.0
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2017-06-10 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 15:33 [PATCH] topology: delete output file if parsing fails Liam Girdwood
2017-06-10 9:35 ` Takashi Iwai [this message]
2017-06-12 17:44 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7f0k2nil.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).