From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 9/9] ctl: add test program for control element set Date: Thu, 16 Jun 2016 15:52:17 +0200 Message-ID: References: <1466002665-30048-1-git-send-email-o-takashi@sakamocchi.jp> <1466002665-30048-10-git-send-email-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id E11EF2669F9 for ; Thu, 16 Jun 2016 15:52:20 +0200 (CEST) In-Reply-To: <1466002665-30048-10-git-send-email-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, clemens@ladisch.de, ffado-devel@lists.sf.net List-Id: alsa-devel@alsa-project.org On Wed, 15 Jun 2016 16:57:45 +0200, Takashi Sakamoto wrote: > > The feature of control element set has been abandoned for a long time since > firstly introduced in 2003 (approx). Furthermore, there's few applications > to utilize this feature. These situations bring a hard work to the persons > who need the feature. Especially, a lack of test program make it harder to > fix much bugs in this feature. > > This commit adds a test program as a sample of the feature. This program > adds element sets of each element type to 'hw:0' in this order; boolean, > integer, enumerated, bytes, IEC958 and integer64. Each iteration includes > below scheme: > > 1. add an element set with 900 elements. Each of them has maximum number > of members allowed by ALSA ctl core. > 2. check all of events generated by above operation. > 3. retrieve information of each element, then validate it. > 4. unlock each member of all elements because they're initially locked. > 5. write to all of members in all elements and read. > 6. check all of events generated by above operation. > 7. write information for threshold level to the element set and read it. > 8. check all of events generated by above operation. > 9. remove the element set. > 10.check all of events generated by above operation. > > When any of these operations fail, it means regression occurs. Then, added > elements still remain in a certain sound card. In this case, unloading > drivers corresponding to the card is an easy way to recover. > > Besides, this program doesn't perform below element operations of ALSA ctl > feature: > - list > - lock > - replace > > Signed-off-by: Takashi Sakamoto The contents are good, but could you reformat it in kernel coding style, i.e. with a hard tab and indent level 8? We aren't so strict in alsa user-space stuff, but it's still better to have some unified style. I already applied all other patches, so just resubmit only this one. thanks, Takashi