Re: ALSA 1.0.0pre3 release

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

At Wed, 26 Nov 2003 17:38:04 +0100,
Thomas Charbonnel wrote:
> 
> Takashi Iwai wrote :
> > Hi,
> > 
> > right now the ALSA 1.0.0pre3 packages are released.
> > 
> > In this version, alsa-tools package was divided to two several ones,
> > alsa-tools and alsa-firmware.  The latter contains only the firmware
> > binary files required by loader programs in alsa-tools package.
> > Please test them if you have a board requiring the loader (hdsp,
> > mixart, vx, usx2y).
> > 
> > Especially, HDSP users, please test and report whether it works, since
> > the hdsploader was modified to load the files dynamically.
> > 
> > 
> > Changes
> > 
> > - usb-audio driver supports async unlinking.
> >   On 2.6 kernels, it's enabled as default, but on older kenrels, it's
> >   disabled to avoid a serious usb-uhci bug.  If you have another
> >   controller, please try the module option async_unlink=1.
> > 
> > - hdsp driver update (including H9652 bugfixes).
> > 
> > - support of more Tascam USxxx devices.
> > 
> > - Audiotrak Prodigy bugfixes.
> > 
> > - fixed noise on vx222 with 24bit mode.
> >    
> > - complation fixes on alsa-drivers.
> >   The 2.2 kernel is still not tested well.  If you can test it, please
> >   let us know.
> > 
> > - fixed CM8738-MC6 5.1 alias.
> > 
> > - alsaconf fix for RH, Fedora and Mandrake.
> > 
> > - hdsp* tools updates.  compilation fixes.
> > 
> > 
> > --
> > Takashi Iwai <tiwai@suse.de>		ALSA Developer - www.alsa-project.org
> 
> Takashi it seems that at least for hdsploader (I didn't check the other 
> tools) you forgot the trailing / in DATAPATH in Makefile.am, so the 
> program fails to find the firmware file :
> Unable to open file 
> '/usr/local/share/alsa/firmware/hdsploadermultiface_firmware.bin' for 
> reading

oh yes, you're right.
is the attached patch ok?
i'll check it in.


Takashi

[-- Attachment #2: Type: text/plain, Size: 1163 bytes --]

Index: alsa-tools/hdsploader/hdsploader.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-tools/hdsploader/hdsploader.c,v
retrieving revision 1.6
diff -u -r1.6 hdsploader.c
--- alsa-tools/hdsploader/hdsploader.c	25 Nov 2003 16:39:25 -0000	1.6
+++ alsa-tools/hdsploader/hdsploader.c	26 Nov 2003 17:06:40 -0000
@@ -83,16 +83,16 @@
     switch (version.io_type) {
     case Multiface:
 	if (version.firmware_rev == 0xa) {
-	    err = read_bin_file(code, DATAPATH "multiface_firmware.bin");
+	    err = read_bin_file(code, DATAPATH "/multiface_firmware.bin");
 	} else {
-	    err = read_bin_file(code, DATAPATH "multiface_firmware_rev11.bin");
+	    err = read_bin_file(code, DATAPATH "/multiface_firmware_rev11.bin");
 	}
 	break;
     case Digiface:
 	if (version.firmware_rev == 0xa) {
-	    err = read_bin_file(code, DATAPATH "digiface_firmware.bin");
+	    err = read_bin_file(code, DATAPATH "/digiface_firmware.bin");
 	} else {
-	    err = read_bin_file(code, DATAPATH "digiface_firmware_rev11.bin");
+	    err = read_bin_file(code, DATAPATH "/digiface_firmware_rev11.bin");
 	}
 	break;
     default: