From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2AD4C7EE2E for ; Mon, 27 Feb 2023 23:49:24 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1C810826; Tue, 28 Feb 2023 00:48:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1C810826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1677541762; bh=6rRSWIUOyV/bPjpPtcg6s2wLKCzUHg+yUcTGaXmWvSY=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mLAWv7TdHz2WN8B4gcXwcYBosT2OFVPEQZ/QjnrZ4NkmHSpoZd5yqZ8HjW2kJXcfs nxVgySHDMgSjXiQQXKwhn1IqEm6/DNNTcy4TXT1Bhw7wr0fiwymdNI9up64UOS8sIN 08Wlh5Bu23PhiWptcJzNnedkxB27/8tP+Y1gN1qg= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9311DF8049C; Tue, 28 Feb 2023 00:48:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3E3D2F8049C; Tue, 28 Feb 2023 00:48:09 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C4C86F800BA for ; Tue, 28 Feb 2023 00:48:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C4C86F800BA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xQwK0UHB; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yIkjKxxH Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 19AAD1FDA9; Mon, 27 Feb 2023 23:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677541683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3i/mCxhNSrbvf9Qr3qMeM0ojflb+JEmsr0zh2f/Sg0g=; b=xQwK0UHBSe4Pvzau9AkBlToN9kwZe015gxGbBDNnuQDWfnhIyDN9/r/Et0Gs1HBI4i9Vnz d+jE6TNXKprHvm63hjaXTxWxIfgBSFHMo1AvuO4tASfUd6VdqFynqiJ6M7o62AwCcoxCRC eh3ZoRHBZB3J9mm9bQyPnhIqksWjk2Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677541683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3i/mCxhNSrbvf9Qr3qMeM0ojflb+JEmsr0zh2f/Sg0g=; b=yIkjKxxHFS3Gbf+d/wgoGqlt8hPK9tOidbFt4BZGGT7XD5MJM9cug+EgZPho+UDc2ZKAzP /N/7ArhiP+XMk5Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0319313A43; Mon, 27 Feb 2023 23:48:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sAZgADNB/WP5awAAMHmgww (envelope-from ); Mon, 27 Feb 2023 23:48:03 +0000 Date: Tue, 28 Feb 2023 00:48:02 +0100 Message-ID: From: Takashi Iwai To: Richard Fitzgerald Subject: Re: [PATCH v2 1/3] ALSA: hda: cs35l41: Correct error condition handling In-Reply-To: References: <20230213145008.1215849-1-sbinding@opensource.cirrus.com> <20230213145008.1215849-2-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: ALA7SNWAX5ZVI4ZGF3UPWSPZWOXJ6SKF X-Message-ID-Hash: ALA7SNWAX5ZVI4ZGF3UPWSPZWOXJ6SKF X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefan Binding , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Vitaly Rodionov , Martin Wolf X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 26 Feb 2023 12:16:43 +0100, Richard Fitzgerald wrote: > > On 13/2/23 14:50, Stefan Binding wrote: > > From: Vitaly Rodionov > > > > Function cs_dsp_coeff_write_ctrl() can return 3 possible values: > > 0 - no change, 1 - value has changed and -1 - error, so positive value > > is not an error. > > Fixes: 7406bdbc4fb8 ("ASoC: wm_adsp: Return whether changed when writing controls") > > > > Signed-off-by: Vitaly Rodionov > > Signed-off-by: Stefan Binding > > --- > > sound/pci/hda/hda_cs_dsp_ctl.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sound/pci/hda/hda_cs_dsp_ctl.c b/sound/pci/hda/hda_cs_dsp_ctl.c > > index 5433f6227ac9..463ca06036bf 100644 > > --- a/sound/pci/hda/hda_cs_dsp_ctl.c > > +++ b/sound/pci/hda/hda_cs_dsp_ctl.c > > @@ -218,10 +218,10 @@ int hda_cs_dsp_write_ctl(struct cs_dsp *dsp, const char *name, int type, > > cs_ctl = cs_dsp_get_ctl(dsp, name, type, alg); > > ret = cs_dsp_coeff_write_ctrl(cs_ctl, 0, buf, len); > > mutex_unlock(&dsp->pwr_lock); > > - if (ret) > > + if (ret < 0) > > return ret; > > - if (cs_ctl->flags & WMFW_CTL_FLAG_SYS) > > + if (ret == 0 || (cs_ctl->flags & WMFW_CTL_FLAG_SYS)) > > return 0; > > ctl = cs_ctl->priv; > > Hi Takashi > > Could you queue this patch as a bugfix for 6.2 please? > The cs_dsp patch to return 1 for changed has gone into 6.2 > but we missed that this hda_cs_dsp code would break. Could you just request the cherry-pick of the necessary fix commits via stable@vger.kernel.org (with Cc to Greg / Sasha)? I've been still traveling in this week, so it's better for you doing that by yourself. thanks, Takashi