From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC30C433DB for ; Sun, 28 Feb 2021 08:13:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7713A64E21 for ; Sun, 28 Feb 2021 08:13:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7713A64E21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BA2AC1666; Sun, 28 Feb 2021 09:13:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BA2AC1666 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614500035; bh=P2HPsJ7vxsrHydEZjsJs2WLEPBUqHBL3xEuqF/EOOmc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r7pFtzRHNgD3vRBu9jCqHNFIh28SgyyVKsVmN5tB4G/Hkr72ONcBWRxKb9mIWzu09 q5jpE5XNR8YlHnRB0nYF/f1ip+jfLRNqtePFGk414JA3/R9d6wnc7uJnDTpHyIuShm ZvDPAHlDyt0QmO+baFzInTk4EVLCW1jjHhTARdf4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 37F78F80227; Sun, 28 Feb 2021 09:13:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 800A8F8025B; Sun, 28 Feb 2021 09:13:03 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3E35CF8010A for ; Sun, 28 Feb 2021 09:12:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3E35CF8010A X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F07BAAB8C; Sun, 28 Feb 2021 08:12:54 +0000 (UTC) Date: Sun, 28 Feb 2021 09:12:54 +0100 Message-ID: From: Takashi Iwai To: Colin King Subject: Re: [PATCH] ALSA: ctxfi: cthw20k2: fix mask on conf to allow 4 bits In-Reply-To: <20210227001527.1077484-1-colin.king@canonical.com> References: <20210227001527.1077484-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Pierre-Louis Bossart , Takashi Iwai , Wai Yew CHAY X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 27 Feb 2021 01:15:27 +0100, Colin King wrote: > > From: Colin Ian King > > Currently the mask operation on variable conf is just 3 bits so > the switch statement case value of 8 is unreachable dead code. > The function daio_mgr_dao_init can be passed a 4 bit value, > function dao_rsc_init calls it with conf set to: > > conf = (desc->msr & 0x7) | (desc->passthru << 3); > > so clearly when desc->passthru is set to 1 then conf can be > at least 8. > > Fix this by changing the mask to 0xf. > > Fixes: 8cc72361481f ("ALSA: SB X-Fi driver merge") > Signed-off-by: Colin Ian King Applied, thanks. Takashi