From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F15C433DF for ; Thu, 11 Jun 2020 17:12:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EEEC20792 for ; Thu, 11 Jun 2020 17:12:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="b3x5spTt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EEEC20792 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA829167C; Thu, 11 Jun 2020 19:11:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA829167C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591895532; bh=IGohR+p9QQIvA8JJS3MI1i6BKs+ZJotrEMlBqWnz9w4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=b3x5spTtH6PYoJ6TDqQVytE2S4uKIdMUHY6HirG+sQjqtyW2Rj6Plh/d0xXVwyeMW WAlfeFGv3BiYanAu2WxUMJQZTIjMIyKxs4pf4FkGIPokMBZ8RvMmETGFdNVbItvatK 7Qp1NGc+oAvvebx7FHs0g3KK12gO7ndR82kRSqTc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7BF06F80278; Thu, 11 Jun 2020 19:11:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 445F3F8028C; Thu, 11 Jun 2020 19:11:20 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C5806F800CC for ; Thu, 11 Jun 2020 19:11:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C5806F800CC X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 783C5AE69; Thu, 11 Jun 2020 17:11:19 +0000 (UTC) Date: Thu, 11 Jun 2020 19:11:14 +0200 Message-ID: From: Takashi Iwai To: "Alex Xu (Hello71)" Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash In-Reply-To: <1591885264.uk6f214o4o.none@localhost> References: <20200520111136.GA3802@amd> <1591545088.74ii116nf2.none@localhost> <20200608061950.GA17476@lst.de> <1591624340.z01ejtod28.none@localhost> <20200609114733.GA1621@lst.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, x86@kernel.org, rientjes@google.com, tiwai@suse.com, linux-kernel@vger.kernel.org, hch@infradead.org, mingo@redhat.com, bp@alien8.de, Pavel Machek , hpa@zytor.com, tglx@linutronix.de, Christoph Hellwig X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 11 Jun 2020 16:51:55 +0200, Alex Xu (Hello71) wrote: > > Excerpts from Takashi Iwai's message of June 9, 2020 11:12 am: > > On Tue, 09 Jun 2020 13:47:33 +0200, > > Christoph Hellwig wrote: > >> > >> Alex, can you try this patch? > > > > Also could you check whether just papering over the memset() call > > alone avoids the crash like below? For PulseAudio and dmix/dsnoop, > > it's the only code path that accesses the vmapped buffer, I believe. > > > > If this works more or less, I'll cook a more comprehensive fix. > > > > > > thanks, > > > > Takashi > > > > --- a/sound/core/pcm_native.c > > +++ b/sound/core/pcm_native.c > > @@ -754,9 +754,11 @@ static int snd_pcm_hw_params(struct snd_pcm_substream *substream, > > while (runtime->boundary * 2 <= LONG_MAX - runtime->buffer_size) > > runtime->boundary *= 2; > > > > +#if 0 > > /* clear the buffer for avoiding possible kernel info leaks */ > > if (runtime->dma_area && !substream->ops->copy_user) > > memset(runtime->dma_area, 0, runtime->dma_bytes); > > +#endif > > > > snd_pcm_timer_resolution_change(substream); > > snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP); > > > > Sorry, this patch doesn't work for me with SME off using abfbb29297c2. > David's newest submitted patch works for me, which I already replied to > separately. Thanks, so something still missing in the mmap handling, I guess. I've worked on two different branches for potential fixes of your problems. Could you test topic/dma-fix and topic/dma-fix2 branches? git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git Just pull one of them onto Linus' git HEAD. I guess we'll go with David's new patch, but still it's interesting whether my changes do anything good actually. Takashi