From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AF8C5518A for ; Wed, 22 Apr 2020 09:30:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD34C206B8 for ; Wed, 22 Apr 2020 09:30:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rHiNFHyF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD34C206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4CDA516A9; Wed, 22 Apr 2020 11:29:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4CDA516A9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587547841; bh=KOMtGcPJ4awezw3qNB3ASnqu86JURENpy671HJEV2o4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rHiNFHyFQwpwj4sflsU2UngchRxfPwxPfRq3yE383ZDfsPN6bv/xCQASWPjiqkc+f 6l7sheBaDtxr7RTVZZVwym9kc50uQGIglvHFmmwz/18NXB8ogzkrEQkRX2PHkEF1/6 v9Vu3gJy3xGQT40cBZBiy9dOoQVMcRyCwLARbdss= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3C8BEF80142; Wed, 22 Apr 2020 11:29:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E7E3AF800F2; Wed, 22 Apr 2020 11:29:46 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C2CD1F800F2 for ; Wed, 22 Apr 2020 11:29:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C2CD1F800F2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 02756AD5C; Wed, 22 Apr 2020 09:29:41 +0000 (UTC) Date: Wed, 22 Apr 2020 11:29:42 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Subject: Re: [PATCH] ALSA: usb-audio: Fix a limit check in proc_dump_substream_formats() In-Reply-To: <20200422092255.GB195357@mwanda> References: <20200422092255.GB195357@mwanda> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Allison Randal X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 22 Apr 2020 11:22:55 +0200, Dan Carpenter wrote: > > This should be ARRAY_SIZE() instead of sizeof(). The sizeof() limit is > too high so it doesn't work. > > Fixes: 093b8494f299 ("ALSA: usb-audio: Print more information in stream proc files") > Signed-off-by: Dan Carpenter Thanks, applied. Takashi