From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: hda/realtek - Enable jack detection
	for Intel CFL + ALC700
Date: Tue, 14 Nov 2017 15:31:41 +0100
Message-ID: <s5h8tf99bjm.wl-tiwai@suse.de>
References: <20171114030008.858-1-guneshwor.o.singh@intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 9551B266A73
 for <alsa-devel@alsa-project.org>; Tue, 14 Nov 2017 15:31:42 +0100 (CET)
In-Reply-To: <20171114030008.858-1-guneshwor.o.singh@intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Guneshwor Singh <guneshwor.o.singh@intel.com>
Cc: PeiSen Hou <pshou@realtek.com>, ALSA ML <alsa-devel@alsa-project.org>, kailang@realtek.com, CHLin <doomko@realtek.com>
List-Id: alsa-devel@alsa-project.org

On Tue, 14 Nov 2017 04:00:08 +0100,
Guneshwor Singh wrote:
> 
> From: PeiSen Hou <pshou@realtek.com>
> 
> ALC700 has jack detection disabled by default in Intel Coffeelake
> Reference board. To enable it, this fixup is required.
> 
> Signed-off-by: PeiSen Hou <pshou@realtek.com>
> Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
> ---
>  sound/pci/hda/patch_realtek.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 0ce71111b4e3..61ef08173b1c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5264,6 +5264,7 @@ enum {
>  	ALC233_FIXUP_LENOVO_MULTI_CODECS,
>  	ALC294_FIXUP_LENOVO_MIC_LOCATION,
>  	ALC700_FIXUP_INTEL_REFERENCE,
> +	ALC700_FIXUP_INTEL_CFL,
>  };
>  
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -6074,6 +6075,21 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{}
>  		}
>  	},
> +	[ALC700_FIXUP_INTEL_CFL] = {
> +		.type = HDA_FIXUP_VERBS,
> +		.v.verbs = (const struct hda_verb[]) {
> +			/* Enables internal speaker */
> +			{0x20, AC_VERB_SET_COEF_INDEX, 0x45},
> +			{0x20, AC_VERB_SET_PROC_COEF, 0x5289},
> +			{0x20, AC_VERB_SET_COEF_INDEX, 0x4a},
> +			{0x20, AC_VERB_SET_PROC_COEF, 0x201b},

I see only one bit here is different from the previous quirk for Intel
reference board.  Do we really need to keep both quirks separately?
Or maybe this new one is the correct verb in anyway?


thanks,

Takashi