From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: portability patch: EBADF [was Re: feeding back pkgsrc changs] Date: Wed, 24 Feb 2016 16:36:36 +0100 Message-ID: References: <20160218154744.GA7454@danbala.tuwien.ac.at> <20160223140906.GP19194@danbala.tuwien.ac.at> <20160224131655.GA22682@danbala.tuwien.ac.at> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id F353726149E for ; Wed, 24 Feb 2016 16:36:36 +0100 (CET) In-Reply-To: <20160224131655.GA22682@danbala.tuwien.ac.at> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Thomas Klausner Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Wed, 24 Feb 2016 14:16:55 +0100, Thomas Klausner wrote: > > On Tue, Feb 23, 2016 at 04:53:51PM +0100, Takashi Iwai wrote: > > On Tue, 23 Feb 2016 15:09:06 +0100, > > Thomas Klausner wrote: > > > Thanks for the answer. > > > > > > On Thu, Feb 18, 2016 at 04:51:15PM +0100, Takashi Iwai wrote: > > > > On Thu, 18 Feb 2016 16:47:44 +0100, > > > > Thomas Klausner wrote: > > > > > I've just updated the pkgsrc packages for alsa-lib, alsa-utils and > > > > > alsa-plugins to 1.1.0 and noticed that there are quite a number of > > > > > local patches we have. I'd like to get them integrated. > > > > > > > > > > When I visited the alsa-projects web page, I noticed that the link to > > > > > the bug tracker is dead. > > > > > > > > > > What is the recommended method to provide the patches? > > > > > > > > Just submit your patches to alsa-devel ML. That's the best way to > > > > review and get merged. > > > > > > I'll start with a straightforward one. Some operating systems don't > > > provide an errno 'EBADFD'; let's use EBADF there instead. > > > > > > This patch adds the define in all files that need it, but if you > > > prefer to add it to a central place instead, please suggest one. > > > > How about put this in include/local.h instead? Then we need to put it > > only in one place, as this is supposed to be included by all codes. > > Sounds good and works. New patch attached. Applied now. Thanks. Takashi