From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: compress: Add DSP private metadata interface Date: Tue, 23 Feb 2016 10:31:18 +0100 Message-ID: References: <1456163671-40987-1-git-send-email-tim.sheridan@imgtec.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6C8282605B4 for ; Tue, 23 Feb 2016 10:31:19 +0100 (CET) In-Reply-To: <1456163671-40987-1-git-send-email-tim.sheridan@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Tim Sheridan Cc: Vinod Koul , alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com List-Id: alsa-devel@alsa-project.org Add Vinod to Cc. On Mon, 22 Feb 2016 18:54:31 +0100, Tim Sheridan wrote: > > Provides an area to communicate with a DSP to implement support for > weird and wonderful features of DSP hardware that aren't supported in > the compress offload API. > > Signed-off-by: Tim Sheridan Don't you have the code actually implement this ioctl? Or, is there anything I miss? thanks, Takashi > --- > include/uapi/sound/compress_offload.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h > index e00d8cb..65ac445 100644 > --- a/include/uapi/sound/compress_offload.h > +++ b/include/uapi/sound/compress_offload.h > @@ -30,7 +30,7 @@ > #include > > > -#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 2) > +#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 3) > /** > * struct snd_compressed_buffer - compressed buffer > * @fragment_size: size of buffer fragment in bytes > @@ -150,6 +150,8 @@ struct snd_compr_metadata { > * SNDRV_COMPRESS_SET_PARAMS: Set codec and stream parameters > * Note: only codec params can be changed runtime and stream params cant be > * SNDRV_COMPRESS_GET_PARAMS: Query codec params > + * SNDRV_COMPRESS_SET_DSP_PRIV: Set private DSP metadata > + * SNDRV_COMPRESS_GET_DSP_PRIV: Get private DSP metadata > * SNDRV_COMPRESS_TSTAMP: get the current timestamp value > * SNDRV_COMPRESS_AVAIL: get the current buffer avail value. > * This also queries the tstamp properties > @@ -171,6 +173,8 @@ struct snd_compr_metadata { > struct snd_compr_metadata) > #define SNDRV_COMPRESS_GET_METADATA _IOWR('C', 0x15,\ > struct snd_compr_metadata) > +#define SNDRV_COMPRESS_SET_DSP_PRIV _IOW('C', 0x16, struct snd_compr_metadata) > +#define SNDRV_COMPRESS_GET_DSP_PRIV _IOWR('C', 0x17, struct snd_compr_metadata) > #define SNDRV_COMPRESS_TSTAMP _IOR('C', 0x20, struct snd_compr_tstamp) > #define SNDRV_COMPRESS_AVAIL _IOR('C', 0x21, struct snd_compr_avail) > #define SNDRV_COMPRESS_PAUSE _IO('C', 0x30) > -- > 1.7.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >