From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/3] ucm: fix variable mixup
Date: Wed, 11 Feb 2015 12:43:05 +0100
Message-ID: <s5h8ug4ptbq.wl-tiwai@suse.de>
References: <1423600954-8751-1-git-send-email-tanu.kaskinen@linux.intel.com>
 <1423600954-8751-2-git-send-email-tanu.kaskinen@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id DD0C9261AC3
 for <alsa-devel@alsa-project.org>; Wed, 11 Feb 2015 12:43:05 +0100 (CET)
In-Reply-To: <1423600954-8751-2-git-send-email-tanu.kaskinen@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Tue, 10 Feb 2015 22:42:32 +0200,
Tanu Kaskinen wrote:
> 
> I assume the intention was to use cdev1 for PlaybackCTL and cdev2 for
> CaptureCTL, but cdev1 was being used for both and cdev2 was not used
> for anything.

Applied, thanks.


Takashi

> ---
>  src/ucm/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ucm/main.c b/src/ucm/main.c
> index 182f174..3924aee 100644
> --- a/src/ucm/main.c
> +++ b/src/ucm/main.c
> @@ -308,7 +308,7 @@ static int execute_sequence(snd_use_case_mgr_t *uc_mgr,
>  					uc_error("cdev is not defined!");
>  					return err;
>  				}
> -				err = get_value3(&cdev1, "CaptureCTL",
> +				err = get_value3(&cdev2, "CaptureCTL",
>  						 value_list1,
>  						 value_list2,
>  						 value_list3);
> -- 
> 1.9.3
>