Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] rawmidi: remove undefined functions.
Date: Fri, 21 Feb 2014 12:06:59 +0100	[thread overview]
Message-ID: <s5h8ut4vi5o.wl%tiwai@suse.de> (raw)
In-Reply-To: <5306B791.4030101@sakamocchi.jp>

At Fri, 21 Feb 2014 11:18:57 +0900,
Takashi Sakamoto wrote:
> 
> >From 1cc92cabd87472deb58a461344c0d70b3ecd93bd Mon Sep 17 00:00:00 2001
> From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Date: Thu, 20 Feb 2014 23:45:39 +0900
> Subject: [PATCH] rawmidi: remove undefined functions.
> 
> 'snd_rawmidi_transmit_reset()' and 'snd_rawmidi_receive_reset()' are declared
> but not defined.
> 
> This state has been continue over 10 years. So let us remove them.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied.


Takashi

> ---
>  include/sound/rawmidi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/sound/rawmidi.h b/include/sound/rawmidi.h
> index adf0885..311dafe 100644
> --- a/include/sound/rawmidi.h
> +++ b/include/sound/rawmidi.h
> @@ -157,10 +157,8 @@ void snd_rawmidi_set_ops(struct snd_rawmidi *rmidi, int stream,
>  
>  /* callbacks */
>  
> -void snd_rawmidi_receive_reset(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_receive(struct snd_rawmidi_substream *substream,
>  			const unsigned char *buffer, int count);
> -void snd_rawmidi_transmit_reset(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_transmit_empty(struct snd_rawmidi_substream *substream);
>  int snd_rawmidi_transmit_peek(struct snd_rawmidi_substream *substream,
>  			      unsigned char *buffer, int count);
> -- 
> 1.8.3.2
> 

      reply	other threads:[~2014-02-21 11:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20 14:59 [PATCH] rawmidi: remove undefined functions Takashi Sakamoto
2014-02-20 15:35 ` Takashi Iwai
2014-02-21  2:18   ` Takashi Sakamoto
2014-02-21 11:06     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8ut4vi5o.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=o-takashi@sakamocchi.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox