From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [SOUND] hda_intel: build fix Date: Mon, 12 Mar 2007 12:04:30 +0100 Message-ID: References: <20070310190513.GA24435@linux-mips.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (ns2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id CE3C22462A for ; Mon, 12 Mar 2007 12:04:30 +0100 (CET) In-Reply-To: <20070310190513.GA24435@linux-mips.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Ralf Baechle Cc: Andrew Morton , alsa-devel@alsa-project.org, perex@suse.cz, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Sat, 10 Mar 2007 19:05:13 +0000, Ralf Baechle wrote: > > CC [M] sound/pci/hda/hda_intel.o > sound/pci/hda/hda_intel.c:1508: error: position_fix_list causes a section type conflict > > Gcc like its __devinitdata readable not const, it seems. An alternative > fix would be to remove the __devinitdata attribute but that would result > in slight runtime bloat. > > Signed-off-by: Ralf Baechle It's no big problem to remove const in these cases, but allowing const with __devinitdata seems the right fix to me... Takashi > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index b9a8e23..63b6854 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -1505,7 +1505,7 @@ static int azx_dev_free(struct snd_device *device) > /* > * white/black-listing for position_fix > */ > -static const struct snd_pci_quirk position_fix_list[] __devinitdata = { > +static struct snd_pci_quirk position_fix_list[] __devinitdata = { > SND_PCI_QUIRK(0x1028, 0x01cc, "Dell D820", POS_FIX_NONE), > {} > }; > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV