From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE69C433DF for ; Mon, 8 Jun 2020 09:23:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 406B5206A4 for ; Mon, 8 Jun 2020 09:23:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="QfjmulRE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 406B5206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CE0DB15E2; Mon, 8 Jun 2020 11:22:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CE0DB15E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591608184; bh=8xuw/nQxVlU3lFQ6rGDwAGO73MvyF2wZrcegp5NnIR0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QfjmulREve7byZE5adsDofDTZTqsIBCprohCTUHWi0u3ntpPwu6KK2cRsdH4qksnq jiPja89uFETztv6P4wwYPuLRUXcgcpVS07/EXod9VdoVbaTSbuqGv8TzjUNRlNyPkK jwLgRhXVL7S4R0Qtsp3aVx50AuQS8iPMdEBlFo4A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 320FEF80276; Mon, 8 Jun 2020 11:22:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AE483F8028A; Mon, 8 Jun 2020 11:22:12 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F21A7F80125 for ; Mon, 8 Jun 2020 11:22:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F21A7F80125 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 60B9AAD81; Mon, 8 Jun 2020 09:22:09 +0000 (UTC) Date: Mon, 08 Jun 2020 11:22:04 +0200 Message-ID: From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH] ALSA: usb-audio: Use the new macro for HP Dock rename quirks In-Reply-To: <0b36a395-0bf3-c853-1640-6356a01e2200@perex.cz> References: <20200608071513.570-1-tiwai@suse.de> <3d4e9e2f-eec9-8018-7964-c09ab81c1240@perex.cz> <0b36a395-0bf3-c853-1640-6356a01e2200@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Kai-Heng Feng X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 08 Jun 2020 11:01:43 +0200, Jaroslav Kysela wrote: > > Dne 08. 06. 20 v 10:44 Takashi Iwai napsal(a): > > On Mon, 08 Jun 2020 10:37:12 +0200, > > Jaroslav Kysela wrote: > >> > >> Dne 08. 06. 20 v 9:15 Takashi Iwai napsal(a): > >>> Replace the open-code with the new QUIRK_DEVICE_PROFILE() macro for > >>> simplicity. > >>> > >>> Fixes: 0c5086f56999 ("ALSA: usb-audio: Add vendor, product and profile name for HP Thunderbolt Dock") > >>> Signed-off-by: Takashi Iwai > >>> --- > >> > >> Takashi, could we export the profile (hint) for new USB cards via the > >> components string - snd_component_add()? The long name seems not > >> appropriate for this. It's a GUI string (which is mangled now). > > > > It's possible, and maybe we should move to it, but we'd need to > > provide in card->longname for now because the component support in > > user-space side isn't in major releases yet. The longname is ugly, > > but that's the only way that works stably right now. > > > > Also, we need a common helper function for adding the component string > > in the kernel side, too, not specific to USB-audio. > > There is already snd_component_add() function, so we need to settle > only the identification prefix for those "model" strings. > > It would be nice to duplicate this info for the moment (the components > string should be shorter than used for long name). Yes, what we need a concrete definition. The implementation in kernel-side must be easy :) > Perhaps, we can just add "hw:" component string for the more > finer hardware identification, like: > > $ amixer -c 0 info > Components : 'USB0bda:58fe hw:VideoMic' I don't mind what form, but would the example above work as a UCM profile properly? thanks, Takashi